Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Feedback shadow for Logic Gates #703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Amadeus1791
Copy link
Contributor

@Amadeus1791 Amadeus1791 commented Mar 2, 2025

This PR updates the shadow figures to be aligned with the new modernized design of the gates done in #676
It also replaces the XOR mode drawing in the gate feedback figures with a more consistent custom fill approach.

Problem with XOR Mode

The previous feedback figures used XOR mode for rendering, which has several drawbacks:

  • Creates white artifacts when shapes overlap with each other
  • Inconsistent appearance depending on background colors
  • Poor visibility against certain backgrounds

Solution

I've replaced XOR mode with a custom fill approach in these feedback figures:

The changes done were:

  1. Remove XOR mode completely
  2. Use dedicated feedback colors (defined in LogicColorConstants)
  3. Maintain the exact shape dimensions and proportions of original figures

new shadow figures for the gates:

2025-03-02 22_28_24-runtime-EclipseApplication(1) - test_fourBitasdfAdder1 logic - Eclipse IDE
2025-03-02 22_28_37-runtime-EclipseApplication(1) - test_fourBitasdfAdder1 logic - Eclipse IDE
2025-03-02 22_27_49-runtime-EclipseApplication(1) - test_fourBitasdfAdder1 logic - Eclipse IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants