Remove unnecessary JsonProperty annotations #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avgustinmm
commented
Feb 21, 2025
•
avgustinmm
commented
- Removed @JsonProperty - no value
- Mix mode with @JsonProperty and no annotation is fixed - only if required = true
- DDI and AMQP messages are made immutable (via JsonCreator and final fields
- All fields renamed to match the json properties - so to be consistent
- getXXXId of the mgmt entities are renamed to getId, getId of the MgmtBaseEntity - removed - self link shall be still available
|
Can one of the admins verify this patch? |
avgustinmm
force-pushed
the
remove_unnecessary_jsonprop_annotations
branch
5 times, most recently
from
db8ee49 to
aa5b0e7
Compare
Signed-off-by: Avgustin Marinov <[email protected]>
avgustinmm
force-pushed
the
remove_unnecessary_jsonprop_annotations
branch
from
aa5b0e7 to
c2d2790
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.