Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3656] Add Message Tracing logs #3657

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

harism
Copy link
Contributor

@harism harism commented Sep 27, 2024

It can be discussed further is the default MessageTracer implementation appropriate to use here.

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add explicit wording to the options and documentation what exactly will be logged when the property is set to true, i.e. headers, payload etc.

@harism
Copy link
Contributor Author

harism commented Oct 12, 2024

Can you please add explicit wording to the options and documentation what exactly will be logged when the property is set to true, i.e. headers, payload etc.

I added those details but might need to improve the documentation still further.

Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for contributing 👍

@sophokles73 sophokles73 merged commit b94163d into eclipse-hono:master Oct 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants