Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 68 bundle iceoryx cpp source #69

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 30, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

This PR added a script to download and bundle the iceoryx C++ sources with the iceoryx-sys crate. This is also recommended procedure from https://kornel.ski/rust-sys-crate#donts

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-68-bundle-iceoryx-cpp-source branch from 433349c to 330c927 Compare July 30, 2023 15:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.27%. Comparing base (68fbd03) to head (330c927).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   55.20%   48.27%   -6.93%     
==========================================
  Files          20       19       -1     
  Lines         942     1075     +133     
==========================================
- Hits          520      519       -1     
- Misses        422      556     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elBoberido elBoberido merged commit 553140e into master Jul 30, 2023
10 of 11 checks passed
@elBoberido elBoberido deleted the iox-68-bundle-iceoryx-cpp-source branch July 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle iceoryx C++ sources for offline builds
2 participants