-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2 Add git hooks #72
Conversation
done | ||
|
||
if [[ ${NUMBER_OF_FILES_WITH_TRAILING_WHITESPACES} -ne 0 ]]; then | ||
echo -e "${COLOR_YELLOW}Please remove the whitespaces and commit the changes with 'git commit --amend --no-edit'${COLOR_OFF}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me like colors
|
||
# This script checks for trailing whitespaces on the modified file and runs 'cargo fmt --check' | ||
|
||
set -eu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this little thing do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The location. In my case European Union. It's us
if you want to use the script from the United States ;)
- e Exit immediately if a command exits with a non-zero status
- u Treat unset variables as an error when substituting
680efa4
to
55d6aee
Compare
e92d735
to
d2af8e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 20 20
Lines 1202 1202
=======================================
Hits 599 599
Misses 603 603 ☔ View full report in Codecov by Sentry. |
Pre-Review Checklist for the PR Author
rustfmt
iox-123-this-is-a-branch
)iox-#42 commit text
)task-list-completed
)Notes for Reviewer
This PR adds some basic git-hooks
cargo fmt
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References