-
Notifications
You must be signed in to change notification settings - Fork 68
[#630] fix: Replace deprecated PanicInfo with direct panic hook implementation #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I've completed the requested changes: applied rustfmt and ensured proper code formatting. |
@elBoberido it seems Bazel does not build since human_panic is no longer required. How would this be cleaned up? |
@Nawazz-ish you need to remove |
@Nawazz-ish oh, you opened a second PR. I guess because of the branch name. Maybe we should rephrase the template to state that it is not a hard requirement for first time contributors. Btw, can you please rebase your branch to main to eliminate the commit from elfenpiff in this PR. Then you can also add the issue number to your first commit. If you need advise on how to do that, don't hesitate to ask. |
@elBoberido I've removed human-panic from BUILD.bazel and cleaned up the commit history as requested. The PR now includes only my commits with the proper issue reference. |
@Nawazz-ish the last thing missing is that you create an account for the eclipse foundation with the same e-mail address you used to commit your stuff to sign the eclipse contributor agreement: https://www.eclipse.org/legal/eca/ If this is done I am happy to merge your changes. |
It's done. I have created an account with the same email. [email protected]. Thanks |
Argh, I have the suspicion that this PR is blocked by a bug in classic iceoryx: eclipse-iceoryx/iceoryx#2422 |
@elfenpiff |
@Nawazz-ish the git commits have Just in case you haven't done it before. If your name and e-mail address is set via
With You also need to add the |
@Nawazz-ish it also seems there are some CI issues unrelated to your PR. We are looking into it and fix it in a separate PR. Of course, if you like, you can also give it a try :) Since more or less the whole team is on a business trip right now, it might take a few days until the CI issue is fixed. @elfenpiff it seems there was a llvm update on FreeBSD. The last successful build hat v15 and now v19 is installed and the build script complains about not finding |
@Nawazz-ish the CI issues are fixed on main. Once you rebase, only the commits need to be fixed |
@Nawazz-ish please rebase to main to get the latest CI fix |
@elBoberido sure will do that ASAP |
@Nawazz-ish oh, just noticed that my last message sounds a bit commanding. One of the github actions we use has had a CVE and it's fixed on the main branch, therefore the somewhat commanding tone :) |
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox2-630
)[#630]
)SPDX-License-Identifier: Apache-2.0 OR MIT
Changes
Testing
References
Closes #630