Only ever return pom path for type=pom

[kwin]

This closes #1730

[github-actions]

Test Results

  214 files  ±0    214 suites  ±0   24m 25s ⏱️ + 6m 39s
  665 tests ±0    642 ✅  - 13  10 💤 ±0  13 ❌ +13 
1 330 runs  ±0  1 284 ✅  - 26  20 💤 ±0  26 ❌ +26 

For more details on these failures, see this check.

Results for commit c6b72f7. ± Comparison against base commit 5f94521.

♻️ This comment has been updated with latest results.

[kwin]

@laeubi Any idea about the failing test cases? They seem related to the change, but I don't understand why.

[laeubi]

Maven requires always a resolved artifact so you need to return something existing for it to work (maybe the basedir of the project) instead of "nothing".

[kwin]

so you need to return something existing for it to work

IMHO returning null here forces Maven to use the regular local Maven repository (instead of using Eclipse source artifacts). I think it is just about test cases setting wrong expectations...

[laeubi]

so you need to return something existing for it to work

IMHO returning null here forces Maven to use the regular local Maven repository (instead of using Eclipse source artifacts). I think it is just about test cases setting wrong expectations...

If Workspace Artifacts are enabled then they must be resolved if possible, return null would mean that the project do not exits in workspace what is wrong.

[akurtakov]

Is there plan to finish this one?

[laeubi]

Is there plan to finish this one?

As mentioned I think the approach is wrong to return null, as it will then mean the artifact is "unresolved".

I also miss a testcase that shows why we change it and that it actually works as expected.

[laeubi]

Closing du to no further feedback @kwin jsut reopen when you plan to work on this again