Add the macros with the hardcoded prefixes #6945
Conversation
github-actions
bot
added
arch:aarch32
arch:aarch64
arch:power
arch:x86
arch:z
comp:compiler
labels
|
The local test results of the code changes in the GitHub pull request is located at the following url: https://drive.google.com/file/d/1OuVzManwMle7SJqRELQP315tafN6YX3U/view?usp=sharing. The local test results of the code changes in the GitHub pull request could be displayed with the file that is located at the following url: https://github.com/singh264/scripts/blob/main/display_test_openj9-openjdk-jdk8_results.sh. |
singh264
requested review from
fjeremic,
aviansie-ben,
0xdaryl,
knn-k,
vijaysun-omr,
Leonardo2718 and
mstoodle
as code owners
|
Sorry just saw this PR, will review the changes later this week |
The code is refactored based on the following GitHub pull request review: eclipse-omr#6945 (review). Closes: eclipse-omr#4550. Author: Amarpreet Singh [email protected].
|
The local test results of the code changes in the GitHub pull request is located at the following url: https://drive.google.com/file/d/19lcbXGXhrajZTzfy08-JWLPv3ZffOLMh/view?usp=sharing. The local test results of the code changes in the GitHub pull request could be displayed with the file that is located at the following url: https://github.com/singh264/scripts/blob/main/display_test_openj9-openjdk-jdk8_results.sh. |
Add the macros with the hardcoded prefixes of format O\^O [a-z A-Z]+(:)?. Issue: eclipse-omr#4550 Signed-off-by: Amarpreet Singh <[email protected]>
The code is refactored based on the following GitHub pull request review: eclipse-omr#6945 (review). Issue: eclipse-omr#4550 Signed-off-by: Amarpreet Singh <[email protected]>
|
https://github.com/singh264/scripts/blob/main/display_test_openj9-openjdk-jdk8_results.sh is not good anymore, @VermaSh I would like you to review this PR as it achieves the same kind of improvement as in the OpenJ9 PR that is similar to this PR. |
Add the macros with the hardcoded prefixes
of format O^O [a-z A-Z]+(:)?.
Issue: #4550
Signed-off-by: Amarpreet Singh [email protected]