AArch64: Add class unload pic to class constant under ifacmp node #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knn-k
reviewed
Dec 14, 2023
| @@ -155,6 +155,11 @@ static TR::Instruction *ificmpHelper(TR::Node *node, TR::ARM64ConditionCode cc, | |||
| TR::RegisterDependencyConditions *deps; | |||
| bool secondChildNeedsRelocation = cg->profiledPointersRequireRelocation() && (secondChild->getOpCodeValue() == TR::aconst) && | |||
| (secondChild->isClassPointerConstant() || secondChild->isMethodPointerConstant()); | |||
| TR_ResolvedMethod *method = comp->getCurrentMethod(); | |||
| bool isSecondChildNeedsPicSite = (secondChild->getOpCodeValue() == TR::aconst) && | |||
There was a problem hiding this comment.
I would suggest changing the variable name to secondChildNeedsPicSite.
There was a problem hiding this comment.
Changed the variable name as suggested.
Class unload pics must be added to class constants so that constants can be invalidated when they are unloaded. aconstEvaluator does add them on AArch64. However, ificmpHelper does not evaluate aconst node if the constant value can be encoded into the immediate field of the cmp instruction. This commit updates ificmpHelper to evaluate aconst node if class unload pic is required. Signed-off-by: Akira Saitoh <[email protected]>
Akira1Saitoh
force-pushed
the
aarch64IfcmpAconst
branch
from
83e1f5d to
67d3ec5
Compare
|
Jenkins build aarch64,amac |
knn-k
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class unload pics must be added to class constants so that constants can be invalidated when they are unloaded. aconstEvaluator does add them on AArch64. However, ificmpHelper does not evaluate aconst node if the constant value can be encoded into the immediate field of the cmp instruction. This commit updates ificmpHelper to evaluate aconst node if class unload pic is required.
Related issue: eclipse-openj9/openj9#18195