Document new DAA api added in 0.46.0 #1506
Conversation
|
Jenkins doc stage |
|
@VermaSh @pshipton - I have updated the docs. Please check and let me know if any other changes are required. https://eclipse-openj9.github.io/openj9-docs-staging/1506/introduction/ |
|
LGTM. Thank you for updating the docs @Sreekala-Gopakumar! |
|
@VermaSh I'm confused. You added a couple of comments for changes, which didn't yet result in any updates, but now say "LGTM". Are there still changes expected? |
Please refer to #1506 (comment). The change that Shubham (@VermaSh) had asked for was already mentioned in the existing content. Therefore, the suggested changes are no longer required. @VermaSh - I hope my understanding is correct. |
|
@pshipton - If any other changes are required, please let me know. Thanks! |
|
Apologies for the misunderstanding, but the requested modifications are no longer necessary. The documentation already emphasizes packed decimal validation, so there's no need to make any changes to the PR. |
|
I expected to see the 0.46 What's new updated to mention the new API. |
|
@VermaSh maybe you can resolve the conversations which are no longer relevant? |
I will do that. I hope the issue that you had mentioned in the following instance will not be applicable in this case. #1489 (comment) Specifically "...we should backdate to 0.49, but because of the TOC changes it would be difficult to refresh 0.49 now." |
|
@pshipton Unfortunately, I don't have the option to mark the conversation as relevant but I have commented "resolved" on the conversations. |
Sreekala-Gopakumar
force-pushed
the
1504ExtDec
branch
from
c8b10b3 to
7bd0472
Compare
|
Jenkins doc stage |
|
@pshipton - Please check and confirm that the changes are ok. Thanks! |
|
@VermaSh does the What's new update look good? |
|
@VermaSh in OpenJ9 pls add a javadoc class description to ExternalDecimal. |
docs/version0.46.md
Outdated
| @@ -35,6 +35,7 @@ The following new features and notable changes since version 0.45.0 are included | |||
| - [New `-XX:[+|-]ShareOrphans` option added](#new-xx-shareorphans-option-added) | |||
| - [New `-XX:[+|-]JITServerAOTCacheIgnoreLocalSCC` option added](#new-xx-jitserveraotcacheignorelocalscc-option-added) | |||
| - [New `-XdynamicHeapAdjustment` option added](#new-xdynamicheapadjustment-option-added) | |||
| - [A new Data Access Accelerator library class and API `com/ibm/dataaccess/ExternalDecimal.checkExternalDecimal` added](#a-new-data-access-accelerator-library-class-and-api-comibmdataaccessexternaldecimalcheckexternaldecimal-added) | |||
There was a problem hiding this comment.
I think just A new Data Access Accelerator (DAA) library API would be better
docs/version0.46.md
Outdated
| @@ -98,6 +99,12 @@ By default, if a checkpoint is taken in a container with no memory limits and th | |||
|
|
|||
| You can now create a single image file and restore it on various nodes with different memory limits. The new option [`-XdynamicHeapAdjustment`](xdynamicheapadjustment.md) automatically adjusts the maximum Java heap size ([`-Xmx`](xms.md)) and minimum Java heap size ([`-Xms`](xms.md)) values such that they are within the physical memory limitations on the system.  | |||
|
|
|||
| ### A new Data Access Accelerator library class and API `com/ibm/dataaccess/ExternalDecimal.checkExternalDecimal` added | |||
|
|
|||
| A new Data Access Accelerator (DAA) library class and API `com/ibm/dataaccess/ExternalDecimal.checkExternalDecimal` is added to verify the validity of the sign and digits of a given external decimal input before operating on the data. | |||
There was a problem hiding this comment.
I think just A new Data Access Accelerator (DAA) library API would be better
eclipse-openj9#1504 OpenJ9 0.46.0 introduced a new Data Access Accelerator library class and API: com/ibm/dataaccess/ExternalDecimal.checkExternalDecimal. This is documented in 0.51.0 release. Added the content in the What's new topic of version 0.46.0 release. Incorporated the feedback. Closes eclipse-openj9#1504 Signed-off-by: Sreekala Gopakumar [email protected]
Sreekala-Gopakumar
force-pushed
the
1504ExtDec
branch
from
7bd0472 to
75d6bc6
Compare
|
Jenkins doc stage |
|
Currently a major outage has impacted a large number of eclipse core services, including the ECA validation service because of which the eclipsefdn/eca check is failing. https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5921 |
#1504
OpenJ9 0.46.0 introduced a new Data Access Accelerator library class and API: com/ibm/dataaccess/ExternalDecimal.checkExternalDecimal. This is documented in 0.51.0 release.
Closes #1504
Signed-off-by: Sreekala Gopakumar [email protected]