Modified -Xmint/-Xmaxt and -Xminf/-Xmaxf for balanced GC #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins doc stage |
1 similar comment
|
Jenkins doc stage |
|
I have updated the -Xmint/-Xmaxt and -Xminf/-Xmaxf related topics based on the modification done for the balanced GC policy (#835). Could you please review the same and let me know if any changes have to be done. Please note that the content that was pending clarification has not been included or modified (#835 (comment)). The What's new in Version 0.30.0 was tidied up and does not require a review since no new content has been added. |
Sreekala-Gopakumar
force-pushed
the
835XmintXmax
branch
from
7c0ce08 to
af5ac7f
Compare
|
Jenkins doc stage |
pshipton
reviewed
Jul 18, 2022
pshipton
reviewed
Jul 18, 2022
|
Jenkins doc stage |
|
@pshipton - I have incorporated the review comment. Is it OK now? |
|
lgtm, but we need @amicic to check it as well. |
pshipton
reviewed
Jul 25, 2022
Edited the What's new in version 0.30.0 topic. Signed-off-by: Sreekala Gopakumar [email protected]
eclipse-openj9#835 -Xmint/-Xmaxt, -Xminf/-Xmaxf, Heap allocation and -Xgcpolicy topics modified to reflect the changes applicable for the balanced GC policy. Included the change specified in eclipse-openj9#833 in xgcpolicy topic. Signed-off-by: Sreekala Gopakumar [email protected]
Sreekala-Gopakumar
force-pushed
the
835XmintXmax
branch
from
719cf3f to
86699a9
Compare
|
Jenkins doc stage |
pshipton
reviewed
Aug 4, 2022
| @@ -89,7 +89,7 @@ The overall size of the LOA is calculated when the heap is initialized, and reca | |||
|
|
|||
| You can control the size of the LOA by using the [`-Xloainitial`, `-Xloaminimum`, and `-Xloamaximum`](xloaminimum.md) command line options. If the LOA is not used, the garbage collector contracts the LOA after a few cycles, down to the value of `-Xloaminimum`. You can also specify [`-Xnoloa`](xloa.md) to prevent an LOA being created. | |||
|
|
|||
| An SOA and LOA are used by the OpenJ9 GC policies: `gencon`, `optavgpause` and `optthruput`. For the `gencon` policy, the LOA and SOA are contained within the tenure area, which is designated for ageing objects. For more information about policies, see [Garbage collection policies](gc.md). | |||
| An SOA and LOA are used by the OpenJ9 GC policies: `gencon`, `optavgpause`, and `optthruput`. For the `gencon` policy, the LOA and SOA are contained within the tenure area, which is designated for ageing objects. For more information about policies, see [Garbage collection policies](gc.md). | |||
There was a problem hiding this comment.
This should be A instead of An, but I won't hold up the merge for this.
pshipton
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#835
-Xmint/-Xmaxt, -Xminf/-Xmaxf, and -Xgcpolicy topics modified to reflect the changes applicable for the balanced GC policy.
Signed-off-by: Sreekala Gopakumar [email protected]