Fix "substract" typo #16431
Fix "substract" typo #16431
Conversation
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
24edca3 to
521cc92
Compare
|
The OMR Acceptance build is not healthy at the moment. I won't launch testing here until that is fixed, as a coordinated merge requires a clean set of tests (or at least I don't want to merge unless that is the case). |
|
Once eclipse-omr/omr#6977 is merged we should be good. |
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk20 depends eclipse-omr/omr#6840 |
|
There are a number of failures from the mock acceptance build above. I would have only expected this PR to cause build problems, not functional issues, so I doubt these are related to this PR. Nevertheless, I'd like to see these tests cleaner than this. Can you rebase both the OMR and OpenJ9 PRs since the known problem in the acceptance build was reverted yesterday, and I will relaunch the tests? If problems persist after that I'll ask you to investigate. Thanks. |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
521cc92 to
b9c9c9d
Compare
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk20 depends eclipse-omr/omr#6840 |
|
Jenkins test sanity.functional xlinux jdk17,jdk20 |
|
Jenkins test sanity.functional,sanity.openjdk xmac jdk20 |
|
Jenkins test sanity.functional,sanity.openjdk aix jdk11 |
|
Jenkins test sanity.openjdk xmac jdk11 depends eclipse-omr/omr#6840 |
|
Jenkins test sanity.openjdk zlinux jdk20 depends eclipse-omr/omr#6840 |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
b9c9c9d to
affe6ab
Compare
|
Just FYI that I won't re-launch the testing above until the OMR acceptance build is clean (it has been unhealthy for over a week now). |
|
I'll rebase this and the OMR PR again once the OMR acceptance build is healthy, and hopefully every goes smoothly from there. |
|
Acceptance build is reasonably stable. May as well rebase this and the OMR PR and we can try again. |
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
affe6ab to
ddd872a
Compare
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk20 depends eclipse-omr/omr#6840 |
1 similar comment
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk20 depends eclipse-omr/omr#6840 |
|
@Spencer-Comin Can you rebase this branch as well just for sanity? |
Signed-off-by: Spencer Comin <[email protected]>
Spencer-Comin
force-pushed
the
fix-substract-typo
branch
from
ddd872a to
0ca4963
Compare
|
Added remaining instances of "substract" that I found through the codebase |
|
I assume this depends on eclipse-omr/omr#6840 , right ? |
|
@r30shah yes, I've updated the description to say that |
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17 depends eclipse-omr/omr#6840 |
|
@Spencer-Comin Can you verify the JDK11 s390 failure are not related to these changes ? |
|
@r30shah The JDK11 failure looks like an instance of #14948 |
|
Jenkins test sanity.openjdk zlinux jdk11 depends eclipse-omr/omr#6840 |
substract -> subtract
depends on eclipse-omr/omr#6840