Add a flag to make get[Process|System]CpuLoad() match RI behaviour #18451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallium
force-pushed
the
getProcessCpuLoad
branch
from
c4067e2 to
74cda0c
Compare
|
@TobiAjila FYI |
|
@ChengJin01 Please review these changes |
ChengJin01
approved these changes
Nov 15, 2023
...gement/share/classes/com/ibm/lang/management/internal/ExtendedOperatingSystemMXBeanImpl.java
Outdated
Show resolved
Hide resolved
tajila
reviewed
Nov 15, 2023
thallium
force-pushed
the
getProcessCpuLoad
branch
from
74cda0c to
356af7d
Compare
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 22, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
getProcessCpuLoad
branch
from
356af7d to
9371cae
Compare
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 22, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
getProcessCpuLoad
branch
from
9371cae to
0cec2e0
Compare
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 23, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 24, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 27, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 27, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 27, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Nov 27, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 5, 2023
This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 6, 2023
…e data point is available This is to help getSystemCpuLoad() determine if it's the first call. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 6, 2023
This is to determine if a call to omrsysinfo_get_CPU_load has onlyone data point recorded. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 6, 2023
This is to determine if a call to omrsysinfo_get_CPU_load has onlyone data point recorded. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 6, 2023
This is to determine if a call to omrsysinfo_get_CPU_load has only one data point recorded. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
|
@thallium Please rebase this PR |
thallium
force-pushed
the
getProcessCpuLoad
branch
2 times, most recently
from
466c2ff to
d2f5475
Compare
|
@tajila Rebased |
|
jenkins test sanity alinux64 jdk17 |
|
jenkins test sanity win jdk8 |
|
@thallium there are some test failures |
tajila
reviewed
Dec 13, 2023
...gement/share/classes/com/ibm/lang/management/internal/ExtendedOperatingSystemMXBeanImpl.java
Show resolved
Hide resolved
tajila
reviewed
Dec 13, 2023
|
See #13389 (comment) |
Currently, getProcessCpuLoad() and getSystemCpuLoad() return -1 if only one data point has been recorded. A compatibility flag -XX:[+/-]CpuLoadCompatibility is added to match the behaviour of the RI, which is to return 0. Fixes: eclipse-openj9#13389 Related: eclipse-omr/omr#7189 Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
getProcessCpuLoad
branch
from
d2f5475 to
a9d62d6
Compare
thallium
changed the title
|
Fixed the logic and commit message. |
|
jenkins test sanity alinux64 jdk17 |
tajila
changed the title
|
@thallium Can you please open a docs issue |
This was referenced Dec 15, 2023
|
Reverted via #18635 |
thallium
added a commit
to thallium/omr
that referenced
this pull request
Dec 17, 2023
This is to determine if a call to omrsysinfo_get_CPU_load has only one data point recorded. Also fixed a mistake in the description saying that the first two invocations return OMRPORT_ERROR_OPFAILED and fix the time unit in the description to "ms". Related: eclipse-openj9/openj9#18451 Signed-off-by: Gengchen Tuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, getProcessCpuLoad() and getSystemCpuLoad() return -1 if only one data point has been recorded. A compatibility flag -XX:[+/-]CpuLoadCompatibility is added to match the behaviour of the RI, which is to return 0.
Fixes: #13389
Related: eclipse-omr/omr#7189