Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete now-unnecessary TR_Removed*Guard guard kinds #18624

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

jdmpapin
Copy link
Contributor

AOT now takes care of generating the TR_Inlined*Method relocations for inlined methods without corresponding guards, so we can remove guards without creating stand-ins.

AOT now takes care of generating the TR_Inlined*Method relocations for
inlined methods without corresponding guards, so we can remove guards
without creating stand-ins.
@jdmpapin
Copy link
Contributor Author

This will need a coordinated merge with eclipse-omr/omr#7205

@jdmpapin jdmpapin requested a review from dsouzai December 13, 2023 22:52
@jdmpapin
Copy link
Contributor Author

@dsouzai, could you please review?

@dsouzai dsouzai self-assigned this Dec 14, 2023
@dsouzai
Copy link
Contributor

dsouzai commented Dec 15, 2023

Jenkins test sanity.functional+aot all jdk17,jdk21 depends eclipse-omr/omr#7205

@dsouzai
Copy link
Contributor

dsouzai commented Dec 18, 2023

aarch64 failures due to #18436
aix failure due to #17396

the zlinux failure I'm not sure I've seen before, but it doesn't look like this change could cause it:

2023-12-16T04:42:54.072Z] Testing: Create and Restore Criu Checkpoint Image once - MethodTypeDeadlockTest
[2023-12-16T04:42:54.072Z] Test start time: 2023/12/16 04:42:53 Coordinated Universal Time
[2023-12-16T04:42:54.072Z] Running command: bash /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criuScript.sh /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java " -Xjit -XX:+CRIURestoreNonPortableMode  -XX:+ThrowOnDelayedCheckpointOperation -XX:sleepMillisecondsForNotCheckpointSafe=20 -Xtrace:print=j9vm.731 --add-opens java.base/jdk.internal.misc=ALL-UNNAMED  --add-exports java.base/openj9.internal.criu=ALL-UNNAMED" org.openj9.criu.DeadlockTest MethodTypeDeadlockTest 1
[2023-12-16T04:42:54.072Z] Time spent starting: 1 milliseconds
[2023-12-16T04:42:59.528Z] Time spent executing: 4918 milliseconds
[2023-12-16T04:42:59.528Z] Test result: FAILED
[2023-12-16T04:42:59.528Z] Output from test:
[2023-12-16T04:42:59.528Z]  [OUT] start running script
[2023-12-16T04:42:59.528Z]  [OUT] export GLIBC_TUNABLES=glibc.cpu.hwcaps=-XSAVEC,-XSAVE,-AVX2,-ERMS,-AVX,-AVX_Fast_Unaligned_Load
[2023-12-16T04:42:59.528Z]  [OUT] export LD_BIND_NOT=on
[2023-12-16T04:42:59.528Z]  [OUT] /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java -XX:+EnableCRIUSupport  -Xjit -XX:+CRIURestoreNonPortableMode  -XX:+ThrowOnDelayedCheckpointOperation -XX:sleepMillisecondsForNotCheckpointSafe=20 -Xtrace:print=j9vm.731 --add-opens java.base/jdk.internal.misc=ALL-UNNAMED  --add-exports java.base/openj9.internal.criu=ALL-UNNAMED -cp /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criu.jar org.openj9.criu.DeadlockTest MethodTypeDeadlockTest 1
[2023-12-16T04:42:59.528Z]  [OUT] Pre-checkpoint
[2023-12-16T04:42:59.528Z]  [OUT] Performing CRIUSupport.checkpointJVM(), current thread name: main, Sat Dec 16 04:42:54 UTC 2023, System.currentTimeMillis(): 1702701774418, System.nanoTime(): 1702701774414903380
[2023-12-16T04:42:59.528Z]  [OUT] JVMJITM044W Some or all compiled code in the code cache invalidated post restore.
[2023-12-16T04:42:59.528Z]  [OUT] Error (criu/protobuf.c:72): Unexpected EOF on (empty-image)
[2023-12-16T04:42:59.528Z]  [OUT] Error (criu/arch/s390/crtools.c:762): Cannot open core for virt pid 2452947: No such file or directory
[2023-12-16T04:42:59.528Z]  [OUT] Error (criu/cr-restore.c:2131): Restoring regs for 2452947 failed: No such file or directory
[2023-12-16T04:42:59.528Z]  [OUT] Error (criu/cr-restore.c:2509): Killing processes because of failure on restore.
[2023-12-16T04:42:59.528Z]  [OUT] The Network was unlocked so some data or a connection may have been lost.
[2023-12-16T04:42:59.528Z]  [OUT] Error (criu/cr-restore.c:2536): Restoring FAILED.
[2023-12-16T04:42:59.528Z]  [OUT] Removed test output files
[2023-12-16T04:42:59.528Z]  [OUT] finished script
[2023-12-16T04:42:59.529Z]  [ERR] /home/jenkins/workspace/Test_openjdk21_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criuScript.sh: line 41: 2452945 Killed                  $2 -XX:+EnableCRIUSupport $3 -cp "$1/criu.jar" $4 $5 $6 > testOutput 2>&1
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: User requested Java dump using]
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: TEST PASSED]
[2023-12-16T04:42:59.529Z] >> Failure condition was not found: [Output match: TEST FAILED]
[2023-12-16T04:42:59.529Z] >> Required condition was found: [Output match: Pre-checkpoint]
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: Checkpoint blocked because thread]
[2023-12-16T04:42:59.529Z] >> Required condition was found: [Output match: Killed]
[2023-12-16T04:42:59.529Z] >> Failure condition was not found: [Output match: CRIU is not enabled]
[2023-12-16T04:42:59.529Z] >> Failure condition was not found: [Output match: Operation not permitted]
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: Thread pid mismatch]
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: do not match expected]
[2023-12-16T04:42:59.529Z] >> Success condition was not found: [Output match: Unable to create a thread:]
[2023-12-16T04:42:59.529Z] >> Failure condition was not found: [Output match: TEST FAILED]
[2023-12-16T04:42:59.529Z] >> Failure condition was not found: [Output match: Could not dump the JVM processes, err=-70]

@dsouzai
Copy link
Contributor

dsouzai commented Dec 18, 2023

Jenkins test sanity.functional+aot zlinux jdk21 depends eclipse-omr/omr#7205

@dsouzai dsouzai merged commit f052734 into eclipse-openj9:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants