Fix implicit conversion causing truncation warnings #18633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzongaro @dylanjtuttle : successfully completed internal testing of OMR Acceptance tests for JDK21 on AIX, pLinux, M-series macOS, and AArch64 Linux. |
hzongaro
reviewed
Dec 18, 2023
Fix AIX/pLinux, Arm, and AArch64 warnings concerning constant values being implicitly converted from an unsigned to a signed type or from a larger to a smaller type which had the potential to cause truncation. Fixes eclipse-openj9#18626 Co-authored-by: Dylan Tuttle <[email protected]> Co-authored-by: Daryl Maier <[email protected]>
0xdaryl
force-pushed
the
constantConversion
branch
from
08775be to
28c8327
Compare
|
Jenkins test sanity aix,plinux,alinux64,amac jdk8,jdk11,jdk17,jdk21 |
|
All the JDK 21 AArch64 CRIU failures appear to be known issues on ub22-aarch64-1. I will re-launch the testing |
|
The re-run of the tests was successful -> https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_aarch64_linux_Personal_testList_1/88/ There are no outstanding issues with this PR testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AIX/pLinux, Arm, and AArch64 warnings concerning constant values being implicitly converted from an unsigned to a signed type or from a larger to a smaller type which had the potential to cause truncation.