JDK next adds JVM_VirtualThreadDisableSuspend #18663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Feng <[email protected]>
pshipton
approved these changes
Dec 20, 2023
|
I merged it already, but shouldn't it be specific to 23 and not 22? jdk22 has branched already. |
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Dec 22, 2023
Enable JVM_VirtualThreadDisableSuspend in JDK22. A PR has been opened to move it to JDK22 in the RI. Eventually, we will see this method in JDK22. The above method is invoked in the VirtualThread class. So, the assertion in the stub will trigger and cause failures in the builds. Leaving the stub empty should be fine. See eclipse-openj9#18671 for more details. Related: - eclipse-openj9#18671 - eclipse-openj9#18667 - eclipse-openj9#18663 Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK next adds
JVM_VirtualThreadDisableSuspendThis fixes JDK next abuild failure https://openj9-jenkins.osuosl.org/job/Build_JDKnext_aarch64_linux_OpenJDK/446/consoleFull
Signed-off-by: Jason Feng [email protected]