Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print footprint statistics using verbose #METHOD STATS #19297

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Print footprint statistics using verbose #METHOD STATS #19297

merged 1 commit into from
Apr 16, 2024

Conversation

gita-omr
Copy link
Contributor

@gita-omr gita-omr commented Apr 11, 2024 •
edited
Loading

Depends on: eclipse-omr/omr#7309

@gita-omr gita-omr requested a review from dsouzai as a code owner April 11, 2024 04:00
@gita-omr
Copy link
Contributor Author

Fixed line endings.

@gita-omr
Copy link
Contributor Author

Cosmetic fix.

@dsouzai dsouzai added comp:jit depends:omr Pull request is dependent on a corresponding change in OMR labels Apr 12, 2024
dsouzai
dsouzai approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsouzai
Copy link
Contributor

dsouzai commented Apr 15, 2024

jenkins test sanity all jdk17 depends eclipse-omr/omr#7309

@dsouzai
Copy link
Contributor

dsouzai commented Apr 15, 2024

I guess the depends command doesn't work because the OMR PR was already merged; will need to wait until that change propagates into the openj9 branch of openj9-omr.

@pshipton
Copy link
Member

jenkins test sanity all jdk17 depends eclipse/omr#master

@dsouzai
Copy link
Contributor

dsouzai commented Apr 16, 2024

x86 failures are due to a known issue

prctl failed @1839 with -1

Will merge once the OMR changes propagate.

@dsouzai dsouzai self-assigned this Apr 16, 2024
@dsouzai dsouzai merged commit f1565c1 into eclipse-openj9:master Apr 16, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsouzai dsouzai dsouzai approved these changes

Assignees

@dsouzai dsouzai

Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gita-omr @dsouzai @pshipton