Add zNext support by r30shah · Pull Request #20507 · eclipse-openj9/openj9

r30shah · 2024-11-05T02:41:29Z

Changes in this PR adds following supporting changes for zNext processor exploitation.

Add zNext facility checks.
Add infrastructure for emulating zNext instruction on older hardware.
Adds emulation for following zNext instructions
- Load Logical Indexed Address
- Load Indexed Address
- Bit deposit and Bit Extract (BDEPG/BEXTG)
- CLZG/CTZG
Accelerate Integer and Long expand and compress methods
- Accelerate Integer.expand, Integer.compress, Long.expand, and
  Long.compress. These methods map directly to the BDEPG and BEXTG
  instructions in zNext.
Accelerate ExternalDecimal.checkExternalDecimal
- Accelerate DAA API for checkExternalDecimal using VTZ instruction.

r30shah · 2024-11-05T02:44:46Z

FYI @dchopra001 @VermaSh @Spencer-Comin

r30shah · 2024-11-08T21:38:44Z

@joransiu @0xdaryl Can we please get review on these changes ?

IBM SDK8 Build with these changes : /build_info.php?build_id=81048

Semeru JDK11/JDK21 build : view/OpenJ9 - Personal/job/Pipeline-Build-Test-Personal/24972/ - In progress.

runtime/compiler/z/runtime/Emulation.cpp

runtime/compiler/z/codegen/J9BCDTreeEvaluator.cpp

r30shah · 2024-11-15T14:28:35Z

@joransiu last set of recommendations were addressed. Can I request for another review?

r30shah · 2025-01-10T18:11:49Z

@joransiu @0xdaryl Can I request a round of review on these changes ? I have rebased the branch with to latest master.

0xdaryl

I was largely looking for structural issues. I'll defer to Joran's review for the zMetis details.

0xdaryl · 2025-01-21T13:48:25Z

Does this PR have any dependencies on eclipse-omr/omr#7525, either breaking or otherwise?

r30shah · 2025-01-21T14:06:41Z

Does this PR have any dependencies on eclipse-omr/omr#7525, either breaking or otherwise?

Yes, there is a dependency and we need to get this and OMR PR merged together (Given the area of the code these two PR touches).

0xdaryl · 2025-01-24T21:05:34Z

Jenkins test sanity.functional,sanity.jdk zlinux,zos jdk21 depends eclipse-omr/omr#7525

0xdaryl · 2025-01-25T12:06:41Z

Jenkins test sanity.functional,sanity.openjdk zlinux,zos jdk21 depends eclipse-omr/omr#7525

0xdaryl · 2025-01-25T12:10:47Z

Jenkins test sanity.functional,sanity.openjdk zlinux jdk21 depends eclipse-omr/omr#7525

r30shah · 2025-01-27T15:00:56Z

Given the merge-conflict in OMR PR, I have made one more change as part of DAA exploitation work to port the required changes from OMR to OpenJ9 - As it fits with DAA acceleration work, I have squashed the change with that commit.

@VermaSh Can I request you to take a look at the change https://github.com/eclipse-openj9/openj9/compare/1a81ab2940ed8f422baab14c560c82f8e7c71f5d..810296f5bd5eae02d937c8e82cd1b119edf9f5b4 to ensure those are the only changes needed.

Take a look at the comment eclipse-omr/omr#7525 (comment)

VermaSh · 2025-01-27T16:06:26Z

@r30shah That seems to have all needed changes.

r30shah · 2025-01-27T16:09:40Z

@r30shah That seems to have all needed changes.

Thanks @VermaSh

@0xdaryl apologies for missing out the merge-conflict (Both OMR and OpenJ9 changes are rebased to latest upstream repo.

0xdaryl · 2025-01-27T18:27:50Z

Jenkins test sanity.functional,sanity.openjdk zlinux jdk21 depends eclipse/omr@7525

r30shah · 2025-01-27T21:15:36Z

Seems like build job failed https://openj9-jenkins.osuosl.org/job/Build_JDK21_s390x_linux_Personal/479/console 1 minute into starting without much helpful message for the reason. Launching another build.

r30shah · 2025-01-27T21:16:43Z

Jenkins test sanity.functional,sanity.openjdk zlinux jdk21 depends eclipse-omr/omr#7525

0xdaryl · 2025-01-28T03:14:43Z

Please see the build failure in the acceptance test build.

Signed-off-by: Spencer Comin <[email protected]>

When running on non zNext hardware, emulating zNext instructions allows testing the exploitation of zNext instructions. Following are the summary of changes being made with this commit. - Add infrastructure to emulate instructions - Emulate following zNext instructions 1. Load indexed address 2. Bit deposit and extract 3. Count leading and trailing zeros Co-authored-by: Dhruv Chopra <[email protected]> Co-authored-by: Shubham Verma <[email protected]> Co-authored-by: Spencer Comin <[email protected]> Signed-off-by: Spencer Comin <[email protected]>

Accelerate Integer.expand, Integer.compress, Long.expand, and Long.compress. These methods map directly to the BDEPG and BEXTG instructions in zNext. - Check if emulation for zNext instruction is enabled and if it is, enable the acceleration of compress and expand with emulation. Signed-off-by: Spencer Comin <[email protected]>

r30shah · 2025-01-28T16:04:19Z

Jenkins line endings check

Accelerate DAA ExternalDecimal.checkExternalDecimal api for verifying Zoned/External decimals using zNext instruction, Vector Test Zoned. This change: - Adds IL opCode for the ExternalDecimal.checkExternalDecimal - Updates IL generator to recognize and inline ExternalDecimal.checkExternalDecimal - Adds evaluator to accelerate the api call via Vector Test Zoned Signed-off-by: Shubham Verma <[email protected]>

Signed-off-by: Rahil Shah <[email protected]>

…al api Signed-off-by: Rahil Shah <[email protected]>

r30shah · 2025-01-28T16:07:41Z

Jenkins test sanity.functional,sanity.openjdk zlinux jdk21 depends eclipse-omr/omr#7525

r30shah marked this pull request as ready for review November 6, 2024 20:35

r30shah requested a review from dsouzai as a code owner November 6, 2024 20:35

r30shah mentioned this pull request Nov 8, 2024

Add zNext support eclipse-omr/omr#7525

Merged

joransiu requested changes Nov 13, 2024

View reviewed changes

r30shah force-pushed the zNextSupportPR branch 3 times, most recently from 01b9c78 to 93008c2 Compare November 14, 2024 19:06

r30shah force-pushed the zNextSupportPR branch from 93008c2 to 22a3427 Compare November 19, 2024 20:34

r30shah force-pushed the zNextSupportPR branch from 22a3427 to 246dcdf Compare December 23, 2024 14:39

r30shah force-pushed the zNextSupportPR branch from 246dcdf to 1a81ab2 Compare January 9, 2025 22:24

joransiu approved these changes Jan 21, 2025

View reviewed changes

0xdaryl added the comp:jit label Jan 21, 2025

0xdaryl approved these changes Jan 21, 2025

View reviewed changes

0xdaryl self-assigned this Jan 21, 2025

0xdaryl added the depends:omr:breaking label Jan 21, 2025

r30shah force-pushed the zNextSupportPR branch from 1a81ab2 to 810296f Compare January 27, 2025 14:57

r30shah force-pushed the zNextSupportPR branch from 810296f to 7c39e69 Compare January 27, 2025 16:09

r30shah force-pushed the zNextSupportPR branch 2 times, most recently from 275d2fe to add57df Compare January 28, 2025 11:37

Spencer-Comin added 3 commits January 28, 2025 08:44

zNext facility checks

4314ea5

Signed-off-by: Spencer Comin <[email protected]>

r30shah force-pushed the zNextSupportPR branch from add57df to a91942b Compare January 28, 2025 13:45

VermaSh and others added 3 commits January 28, 2025 11:06

Address PR Comment: Add emulation support for zNext instructions

de59a99

Signed-off-by: Rahil Shah <[email protected]>

Address PR Comment: Accelerate DAA ExternalDecimal.checkExternalDecim…

7366e65

…al api Signed-off-by: Rahil Shah <[email protected]>

r30shah force-pushed the zNextSupportPR branch from a91942b to 7366e65 Compare January 28, 2025 16:06

0xdaryl approved these changes Jan 29, 2025

View reviewed changes

0xdaryl merged commit c113b72 into eclipse-openj9:master Jan 30, 2025
6 checks passed

Conversation

r30shah commented Nov 5, 2024

Uh oh!

r30shah commented Nov 5, 2024

Uh oh!

r30shah commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

r30shah commented Nov 15, 2024

Uh oh!

r30shah commented Jan 10, 2025

Uh oh!

0xdaryl left a comment

Choose a reason for hiding this comment

Uh oh!

0xdaryl commented Jan 21, 2025

Uh oh!

r30shah commented Jan 21, 2025

Uh oh!

0xdaryl commented Jan 24, 2025

Uh oh!

0xdaryl commented Jan 25, 2025

Uh oh!

0xdaryl commented Jan 25, 2025

Uh oh!

r30shah commented Jan 27, 2025

Uh oh!

VermaSh commented Jan 27, 2025

Uh oh!

r30shah commented Jan 27, 2025

Uh oh!

0xdaryl commented Jan 27, 2025

Uh oh!

r30shah commented Jan 27, 2025

Uh oh!

r30shah commented Jan 27, 2025

Uh oh!

0xdaryl commented Jan 28, 2025

Uh oh!

r30shah commented Jan 28, 2025

Uh oh!

r30shah commented Jan 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants