Delete unused code to make resolved const string CP indices irrelevant #21008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class doesn't exist and (more or less) never did.
Previously the only call site was in ilgen when transforming recognized methods of com/ibm/Compiler/Internal/Prefetch, which it no longer does. With this deletion, the owning method and constant pool index of a const string symref should only matter if it's unresolved. That will make it possible to mark arbitrary (resolved) known object const refs as const strings (whenever they happen to be strings).
|
@0xdaryl, could you please review? |
|
Did you confirm that the prefetch methods are no longer used in any class library code, even internal? If internal only then we may find a better way of dealing with these methods. @zl-wang @r30shah : FYI. I think the prefetching code was only ever used on Power and maybe Z. Can you confirm removing them like this is fine? |
|
I was unable to find any source code for the |
|
have you tried IBM-JDK side? that is the only place i can think of having code outside these repositories. |
|
Yes, but I'll check in privately to make sure I didn't overlook anything |
|
We found no evidence that this |
|
Jenkins test sanity xlinux,plinux,zlinux,alinux jdk21 |
0xdaryl
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com/ibm/Compiler/Internal/Prefetchrecognized methodsTR_J9VMBase::getFieldOffset(), which is now unused