Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust MM_GlobalCollectorDelegate according Coding Standards #21023

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dmitripivkine
Copy link
Contributor

Use uintptr_t instead of UDATA, manage whitespaces

@@ -74,7 +74,7 @@ fixObjectIfClassDying(OMR_VMThread *omrVMThread, MM_HeapRegionDescriptor *region
if (0 != (classFlags & J9AccClassDying)) {
MM_MemorySubSpace *memorySubSpace = region->getSubSpace();
uintptr_t deadObjectByteSize = MM_GCExtensions::getExtensions(omrVMThread)->objectModel.getConsumedSizeInBytesWithHeader(object);
memorySubSpace->abandonHeapChunk(object, ((U_8*)object) + deadObjectByteSize);
memorySubSpace->abandonHeapChunk(object, ((U_8 *)object) + deadObjectByteSize);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint8_t?

@@ -189,7 +189,7 @@ MM_GlobalCollectorDelegate::mainThreadGarbageCollectFinished(MM_EnvironmentBase
while(NULL != (region = regionIterator.nextRegion())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after while

Use uintptr_t instead of UDATA, manage whitespaces

Signed-off-by: Dmitri Pivkine <[email protected]>
@dmitripivkine
Copy link
Contributor Author

Updated

@amicic
Copy link
Contributor

amicic commented Jan 27, 2025

jenkins compile aix jdk11

@amicic amicic merged commit 8ba9385 into eclipse-openj9:master Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants