JDK24 CleanerShutdown invokes CleanerImpl.CleanableList.reset() #21044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR not only fixes #20810, but it also fixes #20835. @JasonFengJ9 Can you also re-enable |
JasonFengJ9
force-pushed
the
cleanershutdown
branch
from
d45c9db to
e93d517
Compare
pshipton
reviewed
Jan 31, 2025
jcl/src/java.base/share/classes/jdk/internal/ref/CleanerShutdown.java
Outdated
Show resolved
Hide resolved
Enabled the thrstatetest and VmArgumentTests. Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
cleanershutdown
branch
from
e93d517 to
5ef42eb
Compare
|
jenkins compile amac jdk21,jdk24 |
|
Tests passed in a grinder https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/4079 |
pshipton
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK24
CleanerShutdowninvokesCleanerImpl.CleanableList.reset()Enabled the
thrstatetestandVmArgumentTests.closes #20810
closes #20835
Signed-off-by: Jason Feng [email protected]