Merged
Conversation
There is a new option to set physical page size/flags for Sparse Heap. Currently this option is going to accept any valid page size, even it is not recommended for Sparse Heap. Any specific limitations can be added later. Signed-off-by: Dmitri Pivkine <[email protected]>
Contributor
Author
|
Tested in internal build |
amicic
reviewed
Jan 31, 2025
| PORT_ACCESS_FROM_JAVAVM(vm); | ||
|
|
||
| pageSizes = j9vmem_supported_page_sizes(); | ||
| pageFlags = j9vmem_supported_page_flags(); |
Contributor
There was a problem hiding this comment.
could initialize at definition line
amicic
reviewed
Jan 31, 2025
| } | ||
|
|
||
| if (!found) { | ||
| const char *oldQualifier, *newQualifier; |
Contributor
There was a problem hiding this comment.
could initialize to null (for gcmetadata too)
amicic
approved these changes
Jan 31, 2025
Contributor
|
jenkins compile aix,win jdk21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new option to set physical page size/flags for Sparse Heap. Currently this option is going to accept any valid page size, even it is not recommended for Sparse Heap. Any specific limitations can be added later.