Improve definition of j9str_printf() #21051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to expect users to provide a pointer to the port library (the macro already assumes access via PORTLIB); this avoids possible problems being used with a different, incompatible argument. At least three parameters must be supplied (so the function in omrstr.c receives at least four). Signed-off-by: Keith W. Campbell <[email protected]>
|
jenkins compile amac jdk11,jdk17,jdk21,jdknext |
|
jenkins compile zlinux jdk8 |
|
jenkins compile alinux jdk8 |
pshipton
approved these changes
Feb 1, 2025
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to expect users to provide a pointer to the port library (the macro already assumes access via
PORTLIB); this avoids possible problems being used with a different, incompatible argument.At least three parameters must be supplied (so the function in
omrstr.creceives at least four).