Update the DIA include in the doc for building Windows jdk8 #21140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
changed the title
keithc-ca
approved these changes
Feb 18, 2025
pshipton
commented
Feb 18, 2025
| @@ -377,7 +377,7 @@ export PATH="/cygdrive/c/Program Files/NASM:$PATH" (in Cygwin) | |||
| Update your `INCLUDE` environment variable to provide a path to the Windows debugging tools with the following command: | |||
|
|
|||
| ``` | |||
| set INCLUDE=C:\Program Files\Debugging Tools for Windows (x64)\sdk\inc;%INCLUDE% | |||
| export INCLUDE=C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\include;%INCLUDE% | |||
There was a problem hiding this comment.
Do I need to change %INCLUDE%?
There was a problem hiding this comment.
The intent here is to use the set command in the Windows cmd.exe context.
There was a problem hiding this comment.
I never run cmd, I just run a cygwin terminal from the start menu. The modified command works for me.
There was a problem hiding this comment.
It's also consistent with the previous commands for updating the PATH.
keithc-ca
reviewed
Feb 19, 2025
| @@ -377,7 +377,7 @@ export PATH="/cygdrive/c/Program Files/NASM:$PATH" (in Cygwin) | |||
| Update your `INCLUDE` environment variable to provide a path to the Windows debugging tools with the following command: | |||
|
|
|||
| ``` | |||
| set INCLUDE=C:\Program Files\Debugging Tools for Windows (x64)\sdk\inc;%INCLUDE% | |||
| export "INCLUDE=C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\include;$INCLUDE" | |||
There was a problem hiding this comment.
Ok, consistently using bash commands is probably better, but this should use single quotes, without the reference to the old value (which is not needed for building Java 8):
export INCLUDE='C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\include'
(so \ characters are taken literally, not as escapes)
Signed-off-by: Peter Shipton <[email protected]>
keithc-ca
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.