Don't use adjacancy check for arraylets in WOC fixup #21144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
force-pushed
the
WOC_adjacency_check
branch
3 times, most recently
from
c1ecf33 to
928a7c8
Compare
dmitripivkine
approved these changes
Feb 19, 2025
When fixing up contiguous reference arrays in Write Once Compactor the rules should be: - pick any, if arraylet mode (offheap disabled) - pick any fully initialized array (dataAddr is set), if offheap enabled mode No need to check if data is adjacent - it's given by these conditions. More so, it's not even correct to use is-adjacent API for arraylet mode. Signed-off-by: Aleksandar Micic <[email protected]>
amicic
force-pushed
the
WOC_adjacency_check
branch
from
928a7c8 to
e546e71
Compare
|
jenkins test sanity xlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fixing up contiguous reference arrays in Write Once Compactor the
rules should be:
offheap enabled mode
No need to check if data is adjacent - it's given by these conditions.
More so, it's not even correct to use is-adjacent API for arraylet mode.