Should-be-adjacent vs is-adjacent data API cleanup #21146
Merged
+36
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
force-pushed
the
should_be_vs_is_adjacent
branch
from
1dc09c3 to
a9c2d19
Compare
amicic
changed the title
In array object model distinguish between APIs: - should be adjacent - is adjacent The former is used early when the object is being constructed, and dataAddr is yet to be initialized. API makes a decision based on size in bytes explicitely provided or read from the array heder, and is used to determine if data should be allocated in main heap or offheap. The latter is used at later points in time (like GC, JNI Critical API) when object is fully initialized. Then the check is about actual dataAddr value (if it points to the end of the header or not). This is faster and simpler check and is preferred, unless dataAddr is not initialized yet. Signed-off-by: Aleksandar Micic <[email protected]>
amicic
force-pushed
the
should_be_vs_is_adjacent
branch
from
a9c2d19 to
232fde5
Compare
|
what is not obvious from the change, the users of is-adjacent (spots that are not replaced to use should-be-adjacent) are:
Hence, there is a small change in behaviour (those spots will do the check based on dataAddr value, rather than the size). |
dmitripivkine
approved these changes
Feb 19, 2025
|
jenkins test sanity xlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In array object model distinguish between APIs:
The former is used early when the object is being constructed, and dataAddr is yet to be initialized. API makes a decision based on size in bytes explicitely provided or read from the array heder, and is used to determine if data should be allocated in main heap or offheap.
The latter is used at later points in time (like GC, JNI Critical API) when object is fully initialized. Then the check is about actual dataAddr value (if it points to the end of the header or not). This is faster and simpler check and is preferred, unless dataAddr is not initialized yet.