Add unused macro to access barrier helpers#21153
Merged
amicic merged 1 commit intoeclipse-openj9:masterfrom Feb 20, 2025
Merged
Add unused macro to access barrier helpers#21153amicic merged 1 commit intoeclipse-openj9:masterfrom
amicic merged 1 commit intoeclipse-openj9:masterfrom
Conversation
When compiling on GCC with O0 (no optimization) it fails with a warning that `9javaArray_##elemType##_EA` functions are defined but unused. This change enables compilation with no optimization to succeed. Signed-off-by: Tobi Ajila <[email protected]>
Contributor
Author
|
jenkins test sanity xlinux jdk17 |
1 similar comment
Contributor
Author
|
jenkins test sanity xlinux jdk17 |
Contributor
Author
|
jenkins compile xlinux jdk17 |
Contributor
Author
|
@amicic Please take a look |
amicic
approved these changes
Feb 20, 2025
Contributor
|
This seems to break windows builds; see ibmruntimes/openj9-openjdk-jdk#943. |
keithc-ca
added a commit
to keithc-ca/openj9
that referenced
this pull request
Feb 20, 2025
Compilers on platforms that don't use GCC (e.g. Windows) were failing. Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
added a commit
to keithc-ca/openj9
that referenced
this pull request
Feb 20, 2025
Compilers on platforms that don't use GCC (e.g. Windows) were failing. Reuse GNU_UNUSED where appropriate. Signed-off-by: Keith W. Campbell <[email protected]>
Member
|
Reverted via #21163, see the description for the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling on GCC with O0 (no optimization) it fails with a warning that
9javaArray_##elemType##_EAfunctions are defined but unused.This change enables compilation with no optimization to succeed.