Skip to content

Pass VENDOR_CODE parameters to build jobs #22049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Jun 5, 2025

@pshipton pshipton force-pushed the passvendor branch 3 times, most recently from 210b215 to b9b9a63 Compare June 5, 2025 14:58
@pshipton
Copy link
Member Author

pshipton commented Jun 5, 2025

jenkins compile amac jdk11

@keithc-ca
Copy link
Contributor

11:10:18 Unknown option: '-vendor-code-reference=/home/jenkins/openjdk_cache'

The extensions repos need to be taught the new options, or that one should only be added if one of the other "vendor-code" options is needed.

@pshipton
Copy link
Member Author

pshipton commented Jun 5, 2025

jenkins compile plinux jdk8 depends ibmruntimes/openj9-openjdk-jdk8#838

@pshipton
Copy link
Member Author

pshipton commented Jun 5, 2025

The extensions repos need to be taught the new options, or that one should only be added if one of the other "vendor-code" options is needed.

I'm aware, see ibmruntimes/openj9-openjdk-jdk8#838

vendor-code isn't a good name, vendor_code would work, but I decided vendor is consistent with ibmruntimes/openj9-openjdk-jdk#1031, if you agree.

@pshipton
Copy link
Member Author

pshipton commented Jun 5, 2025

jenkins compile amac jdk11

@pshipton
Copy link
Member Author

pshipton commented Jun 5, 2025

The amac compilation error is unrelated, caused by #22003

@keithc-ca keithc-ca merged commit 7103757 into eclipse-openj9:master Jun 10, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants