Skip to content

Box and unbox all types in VectorAPIExpansion: restore and fix compile error #22058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Box and unbox all types in VectorAPIExpansion: restore and fix compile error #22058

merged 2 commits into from
Jun 10, 2025

Conversation

gita-omr
Copy link
Contributor

@gita-omr gita-omr commented Jun 7, 2025 •
edited
Loading

  • maintain a cache of all classes that are needed for boxing and unboxing
  • classes are passed to intrinsics, record location of class parameters in the table
  • make sure result type of an intrinsic is stored in the table and used for boxing/unboxing
  • record result type of 'compare' in the methodTable instead of the source type

gita-omr added 2 commits June 6, 2025 19:57
@gita-omr
Box and unbox all types in VectorAPIExpansion
20366cf 
- maintain a cache of all classes that are needed for boxing and unboxing
- classes are passed to intrinsics, record location of class parameters in the table
- make sure result type of an intrinsic is stored in the table and used for boxing/unboxing
- record result type of 'compare' in the methodTable instead of the source type
@gita-omr
Box and unbox all types in VectorAPIExpansion: restore and fix compil…
41a8fed 
…e error
@gita-omr
Copy link
Contributor Author

gita-omr commented Jun 7, 2025

Restoring #22003

@gita-omr
Copy link
Contributor Author

gita-omr commented Jun 7, 2025

Jenkins test sanity aarch64_mac jdk21

@gita-omr
Copy link
Contributor Author

gita-omr commented Jun 7, 2025

Jenkins build zlinux, zos jdk21

@gita-omr
Copy link
Contributor Author

gita-omr commented Jun 7, 2025

Jenkins test sanity zlinux, zos jdk21

@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

Jenkins test sanity zlinux,zos jdk21

1 similar comment
@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

Jenkins test sanity zlinux,zos jdk21

@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

Jenkins test sanity zlinux jdk21

@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

Jenkins test sanity zos jdk21

@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

PR build for zos is not supported.

@knn-k
Copy link
Contributor

knn-k commented Jun 9, 2025

Jenkins test sanity xlinux jdk21

knn-k
knn-k approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@knn-k knn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding #include "il/StaticSymbol.hpp" is the only difference from #22003.
It builds on amac and zlinux with the change.

@knn-k knn-k added the comp:jit label Jun 10, 2025
@knn-k knn-k self-assigned this Jun 10, 2025
@knn-k knn-k merged commit e5dbdc3 into eclipse-openj9:master Jun 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knn-k knn-k knn-k approved these changes

Assignees

@knn-k knn-k

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gita-omr @knn-k