Ignore -Xjcl options #22066
Open
Ignore -Xjcl options #22066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should just delete all this code. I can't remember the original purpose, I suspect it was related to J2ME. The values are never updated so even if there was some incompatibility between the VM and JCL it wouldn't be detected, and I don't think anybody would try to mismatch the VM and JCL code anyway. |
pshipton
reviewed
Jun 9, 2025
Do you mean to say we should delete everything in support of the |
|
Deleting |
Remove: * J9JavaVM.jclDLLName * addXjcl() * checkJCL() * J9SYSPROP_ERROR_INVALID_JCL * J9VMInternals.j9Config * J9VMInternals.j9Version Signed-off-by: Keith W. Campbell <[email protected]>
These NLS messages were only used in support of -Xjcl: * J9NLS_JCL_INCOMPATIBLE_CL * J9NLS_JCL_INCOMPATIBLE_CL_VERSION * J9NLS_JCL_INCOMPATIBLE_CL_VERSION_JCL * J9NLS_JCL_INCOMPATIBLE_CL_VERSION_VM * J9NLS_JCL_NOTJ9 * J9NLS_JCL_TRY_JCL Signed-off-by: Keith W. Campbell <[email protected]>
keithc-ca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely ignore
-Xjcloptions.Remove:
J9JavaVM.jclDLLNameaddXjcl()checkJCL()J9SYSPROP_ERROR_INVALID_JCLJ9VMInternals.j9ConfigJ9VMInternals.j9VersionRemove NLS messages that were only used in support of
-Xjcl:J9NLS_JCL_INCOMPATIBLE_CLJ9NLS_JCL_INCOMPATIBLE_CL_VERSIONJ9NLS_JCL_INCOMPATIBLE_CL_VERSION_JCLJ9NLS_JCL_INCOMPATIBLE_CL_VERSION_VMJ9NLS_JCL_NOTJ9J9NLS_JCL_TRY_JCLEliminates issues discovered while investigating #22056.