Linter Infrastructure to support formatting the Compiler Component #22943
+176
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Irwin D'Souza <[email protected]>
Contributor
Author
|
@AdamBrousseau Does this look reasonable for what we would need to support a Code Format Linter on OpenJ9? Am I missing anything (aside from the actual job(s) on jenkins)? |
dsouzai
commented
Nov 14, 2025
Comment on lines
+24
to
+26
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/compiler/.clang-format runtime/compiler/ | ||
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/Dockerfile buildenv/jenkins/clang_format/ | ||
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/clang-format-wrapper.sh buildenv/jenkins/clang_format/ |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/compiler/.clang-format runtime/compiler/ | |
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/Dockerfile buildenv/jenkins/clang_format/ | |
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/clang-format-wrapper.sh buildenv/jenkins/clang_format/ | |
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/compiler/.clang-format -P runtime/compiler/ | |
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/Dockerfile -P buildenv/jenkins/clang_format/ | |
| wget https://raw.githubusercontent.com/eclipse-omr/omr/refs/heads/master/buildenv/jenkins/clang_format/clang-format-wrapper.sh -P buildenv/jenkins/clang_format/ |
Missed the -P flag.
Contributor
Author
|
@AdamBrousseau reminder ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Proposal #22494.
Depends on eclipse-omr/omr#7939