Introduce a constantPool cache v2 #22974
Conversation
Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled. Signed-off-by: tajila <[email protected]>
|
Yet to reproduce the issue on xlinux, so maybe there is a non obvious platform dependency here. |
|
jenkins test sanity.openjdk amac jdk21 |
| * constantpool associated with clazz | ||
| */ | ||
| public static ConstantPool getConstantPoolFromAnnotationBytes(Class<?> clazz, byte[] array) { | ||
| /* Check the cp cache on the Class object first */ |
There was a problem hiding this comment.
Please finish each sentence with a period (throughout).
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Show resolved
Hide resolved
|
What's different in this one? |
Nothing, Im just trying to reproduce the failure with more debug info. |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity plinux jdk17 |
tajila
force-pushed
the
opt
branch
3 times, most recently
from
eaa45af to
4facbef
Compare
|
jenkins test sanity.openjdk amac jdk21 |
tajila
force-pushed
the
opt
branch
2 times, most recently
from
6cbee62 to
7736698
Compare
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
tajila
force-pushed
the
opt
branch
4 times, most recently
from
2e7a389 to
2db6b17
Compare
|
jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060 |
Signed-off-by: Tobi Ajila <[email protected]>
|
jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060 |
3 participants
Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled.