Fix J9ClassHasIdentity flag assignment#23008
Merged
hangshao0 merged 1 commit intoeclipse-openj9:masterfrom Dec 1, 2025
Merged
Conversation
Set the J9ClassHasIdentity flag only if the class is not a value class and not an interface.
d1e0327 to
ae31000
Compare
theresa-m
suggested changes
Nov 25, 2025
| #endif /* defined(J9VM_OPT_VALHALLA_VALUE_TYPES) */ | ||
| } else if (!(J9_IS_CLASSFILE_OR_ROMCLASS_VALUETYPE_VERSION(romClass) && J9ROMCLASS_IS_INTERFACE(romClass))) { | ||
| /* All classes before value type version are identity. */ | ||
| } else if (!J9ROMCLASS_IS_VALUE(romClass) && !J9ROMCLASS_IS_INTERFACE(romClass)) { |
Contributor
There was a problem hiding this comment.
I think you can remove the interface check here. J9ROMCLASS_IS_VALUE is only true when an interface flag is not set.
Author
There was a problem hiding this comment.
J9ROMCLASS_IS_VALUE is false for interfaces. If I remove the interface check, J9ROMCLASS_IS_VALUE will return false for interfaces and enters the else if block and sets J9ClassHasIdentity flag for interfaces too.
theresa-m
approved these changes
Nov 26, 2025
hangshao0
reviewed
Nov 27, 2025
Contributor
|
Jenkins test sanity.functional,extended plinuxval jdknext |
Contributor
|
Jenkins compile amac jdk21 |
hangshao0
approved these changes
Dec 1, 2025
Contributor
|
@AditiS11 please open a pull request to remove ValueClassTest from https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdkvalhalla-openj9.txt. |
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Dec 4, 2025
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Dec 5, 2025
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Dec 5, 2025
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Dec 10, 2025
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Dec 10, 2025
smlambert
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Dec 10, 2025
Fixed by: eclipse-openj9/openj9#23008 Co-authored-by: Aditi Srinivas M <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the J9ClassHasIdentity flag only if the class is
not a value class and not an interface.
Fixes the following failure in
test/jdk/valhalla/valuetypes/ValueClassTest.java