Enable checks on array copies for String.getBytes()#23449
Enable checks on array copies for String.getBytes()#23449knn-k wants to merge 1 commit intoeclipse-openj9:masterfrom
Conversation
|
Jenkins test sanity xlinux,alinux64 jdk21 |
|
Jenkins test sanity xlinux,alinux64 jdk21 |
|
The following jobs show that RacingSBThreads test passes with this change: |
knn-k
force-pushed
the
fix23353
branch
2 times, most recently
from
62d0a68 to
c8fef04
Compare
|
Jenkins test sanity amac jdk21,jdk25 |
|
Jenkins compile amac jdk21 |
hzongaro
left a comment
hzongaro
left a comment
There was a problem hiding this comment.
I think the change looks good. I hate to nitpick about this, but may I ask you to modify the commit message to remove “PR” from the text, since the commit itself isn’t a PR? Perhaps something like this:
Enable JIT checks on arraycopy operations for String.getBytes() in
Java 21 and older.
|
I updated the commit message as suggested. No change in the code. |
|
Jenkins test sanity amac jdk21 |
Enable JIT checks on arraycopy operations for String.getBytes() in Java 21 and older. Original PR in master: eclipse-openj9#23449 Signed-off-by: KONNO Kazuhiro <[email protected]>
|
This PR only partially fixes #23353 as per my comment: #23353 (comment) and #23353 (comment). Other changes are required to fix JDK8 and JDK11 and my investigation in JDK11 is still ongoing. Should the keyword |
Enable JIT checks on arraycopy operations for String.getBytes() in Java 21 and older. Related issue: eclipse-openj9#23353 Signed-off-by: KONNO Kazuhiro <[email protected]>
|
Thanks. I updated the commit message. |
|
Jenkins test sanity amac jdk21 |
1 similar comment
|
Jenkins test sanity amac jdk21 |
|
@hzongaro Would you merge this PR if it looks good to you, please? Thanks. |
3 participants
Enable JIT checks on arraycopy operations for String.getBytes() in Java 21 and older.
Related issue: #23353