Remove rarely usable Drag&Drop of EEs in Manifest-Editor Overview page #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
remove-unused-EE-DnD
branch
from
87f7d33
to
67bc92c
Compare
|
There are many places where drag and drop would be nice for reordering but this seems at the very bottom of the list of useful places. 👍 |
Drag&drop support was introduced via Bug 192890, but only supports reordering of required Execution-Environments in the same Plug-in project. Because in the vast majority of cases Plug-ins only have one BREE defined, this feature is only rarely usable. And if a Plug-in project really defines multiple BREEs, the Manifest Editor already provides an alternative with the 'Up' and 'Down' buttons next to the table. While being only rarely usable support D&D support for required EEs makes it more difficult to support OSGi EE requirements. Therefore it is removed. [1] - https://bugs.eclipse.org/192890
HannesWell
force-pushed
the
remove-unused-EE-DnD
branch
from
67bc92c
to
5791656
Compare
Absolutely. |
|
I don't even think the order matters at all, so maybe we can even remove the buttons... |
|
+1 for removing DND here. |
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Jul 6, 2024
Also remove CompositeManifestHeader.removeManifestElement(), which is unused since eclipse-pde#1321
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Jul 6, 2024
Also remove CompositeManifestHeader.removeManifestElement(), which is unused since eclipse-pde#1321
HannesWell
added a commit
that referenced
this pull request
Jul 6, 2024
Also remove CompositeManifestHeader.removeManifestElement(), which is unused since #1321
See #1324. |
fedejeanne
pushed a commit
to fedejeanne/eclipse.pde
that referenced
this pull request
Jul 31, 2024
Also remove CompositeManifestHeader.removeManifestElement(), which is unused since eclipse-pde#1321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag&drop support was introduced via Bug 192890, but only supports reordering of required Execution-Environments in the same Plug-in project.
Because in the vast majority of cases Plug-ins only have one EE defined that feature is only rarely usable. And if a Plug-in project really defines multiple BREEs the Manifest Editor already provides an alternative with the 'Up' and 'Down' buttons next to the table.
While being only rarely usable support D&D support for required EEs makes it more difficult to support OSGi EE requirements in #1318.
Therefore I propose to remove it.
@laeubi, @merks or anbody else, do you have any objections?