Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable secret scanning for all repos #1

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2023

We (security team at EF: https://www.eclipse.org/security/team/) would like to enable secret scanning for all of the repos of eclipse projects hosted on GitHub. For that purpose we suggest changes to the configuration that the project leads can review.

@ghost ghost requested review from a team as code owners August 24, 2023 12:47
@github-actions
Copy link

Diff for 1af84c3:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-pdt[id=eclipse-pdt]
  there have been 3 validation infos, enable verbose output with '-v' to to display them.

  
!   repository[name="pdt-website"] {
!     secret_scanning                                          = "disabled" -> "enabled"
!     secret_scanning_push_protection                          = "disabled" -> "enabled"
!   }
  
  Plan: 0 to add, 2 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-pdt[id=eclipse-pdt]

@ghost
Copy link
Author

ghost commented Sep 11, 2023

Hello,

If you require additional information about GitHub Secret scanning before reviewing this pull request, please refer to the following GitHub document: Link to GitHub Document About secret scanning.

Feel free to reach out if you have any questions.

Thank you,
FP

@zulus
Copy link
Member

zulus commented Sep 12, 2023

It's fine to me

@netomi netomi merged commit 8225bca into main Sep 12, 2023
1 check passed
@netomi netomi deleted the enable-secret-scanning branch September 12, 2023 09:37
@netomi
Copy link
Contributor

netomi commented Sep 12, 2023

changes have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants