-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare required jdk and maven as top-level pipeline tools in I-builds #1727
Declare required jdk and maven as top-level pipeline tools in I-builds #1727
Conversation
Since eclipse-platform/eclipse.platform.swt#973 the I-build (like the SWT build) requires a java-17 (or later) jdk on the PATH system environment-variable in order to launch a jdk>=17 with the 'java' command from the CLI. Just setting the JAVA_HOME variable to a path pointing to a jdk-17 is not sufficient since the the java executable is usually located in '$JAVA_HOME/bin'. And while the maven launch script searches in '$JAVA_HOME/bin' for a java executable to run the build itself, a simple java command on the CLI isn't that smart. Previously running the 'java' command would just run the default default java version on the Jenkins executor. In general this simplifies the build-configuration because the JDK to use is only defined once and used everywhere. Fixes eclipse-platform#1724
This is step in the right direction. Please merge and start new I-build so results are seen sooner. |
Done. Is there anything to do to synchronize the change in the groovy file with the actual job-configuration? |
The error was: |
For the record, that behavior of Maven is mentioned in the Maven Installation Guide. |
Applies the following changes to P- and Y-builds: - eclipse-platform#1727 - eclipse-platform#1728
Since eclipse-platform/eclipse.platform.swt#973 the I-build (like the SWT build) requires a java-17 (or later) jdk on the
PATH
system environment-variable in order to launch ajdk>=17
with the 'java' command from the CLI. Just setting theJAVA_HOME
variable to a path pointing to a jdk-17 is not sufficient since the the java executable is usually located in$JAVA_HOME/bin
. And while the maven launch script searches in$JAVA_HOME/bin
for a java executable to run the build itself, a simple java command on the CLI isn't that smart.Previously running the
java
command would just run the default default java version on the Jenkins executor.In general this simplifies the build-configuration because the JDK to use is only defined once and used everywhere.
Hopefully fixes #1724. I have no way to test this in advance but the explanation above is the only one I found why the Maven build itself runs fine (which requires Java-17 because of Tycho), but fails as soon as a
java
command is launched that requires java>=17.