Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Unify and clean-up list of declared CBI plugin-repositories #2539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Member

From the three declared Eclipse CBI plugin repositories only the maven-plugins with groupId 'org.eclipse.cbi.maven.plugins' are obtained. And at least with respect to these mavne-plugins, the repository at

seems to be the combination of the co-located repositories:

Therefore it seems unnecessary to declare all three repositories.

@akurtakov can you tell if my analysis and this change is correct or if not, can you tell who can tell?

@akurtakov
Copy link
Member

The analysis seem to be correct.
Please even remove

<releases>
        <enabled>true</enabled>
      </releases>

as it's the default and just clutters the pom.

From the three declared Eclipse CBI plugin repositories only the
maven-plugins with groupId 'org.eclipse.cbi.maven.plugins' are obtained.
And at least with respect to these mavne-plugins, the repository at
https://repo.eclipse.org/content/repositories/cbi is the combination of
the co-located 'cbi-releases' and 'cbi-snapshot' repository.

Additionally remove superfluous enabled=true tags.
@HannesWell
Copy link
Member Author

The analysis seem to be correct.

Great. Thanks for the confirmation!

Can you tell where the 'merge' happens? In the distribution management of o.e.cbi I can only see the releases and snapshots repo being defined:
https://github.com/eclipse-cbi/org.eclipse.cbi/blob/5d0a693e90524c337f088f91aa0e9432153c5d39/pom.xml#L65-L81

Or is this some kind of virtual repository?

Please even remove

<releases>
        <enabled>true</enabled>
      </releases>

as it's the default and just clutters the pom.

Yes, with joy. According to https://maven.apache.org/pom.html#Repositories and the doc proposed by sonar lint, even snapshots=true is the default. So it can be removed too.

Should we submit this then now or also hold this back until the next dev cycle?

@akurtakov
Copy link
Member

The analysis seem to be correct.

Great. Thanks for the confirmation!

Can you tell where the 'merge' happens? In the distribution management of o.e.cbi I can only see the releases and snapshots repo being defined: https://github.com/eclipse-cbi/org.eclipse.cbi/blob/5d0a693e90524c337f088f91aa0e9432153c5d39/pom.xml#L65-L81

Or is this some kind of virtual repository?

I really have no idea. Maybe @fredg02 can answer that.

Please even remove

<releases>
        <enabled>true</enabled>
      </releases>

as it's the default and just clutters the pom.

Yes, with joy. According to https://maven.apache.org/pom.html#Repositories and the doc proposed by sonar lint, even snapshots=true is the default. So it can be removed too.

Should we submit this then now or also hold this back until the next dev cycle?

Let's do it at once in the next dev cycle.

@fredg02
Copy link
Contributor

fredg02 commented Nov 14, 2024

It's a group repository and it combines the releases and the snapshots repositories. You can also see all of the group repos here:

https://repo.eclipse.org/#view-repositories

@HannesWell
Copy link
Member Author

Should we submit this then now or also hold this back until the next dev cycle?

Let's do it at once in the next dev cycle.

Acknowledge.

It's a group repository and it combines the releases and the snapshots repositories. You can also see all of the group repos here:

https://repo.eclipse.org/#view-repositories

Thank you for the confirmation. Good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants