-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Unify and clean-up list of declared CBI plugin-repositories #2539
base: master
Are you sure you want to change the base?
[Build] Unify and clean-up list of declared CBI plugin-repositories #2539
Conversation
The analysis seem to be correct.
as it's the default and just clutters the pom. |
From the three declared Eclipse CBI plugin repositories only the maven-plugins with groupId 'org.eclipse.cbi.maven.plugins' are obtained. And at least with respect to these mavne-plugins, the repository at https://repo.eclipse.org/content/repositories/cbi is the combination of the co-located 'cbi-releases' and 'cbi-snapshot' repository. Additionally remove superfluous enabled=true tags.
76514b7
to
014d865
Compare
Great. Thanks for the confirmation! Can you tell where the 'merge' happens? In the distribution management of o.e.cbi I can only see the releases and snapshots repo being defined: Or is this some kind of virtual repository?
Yes, with joy. According to https://maven.apache.org/pom.html#Repositories and the doc proposed by sonar lint, even snapshots=true is the default. So it can be removed too. Should we submit this then now or also hold this back until the next dev cycle? |
I really have no idea. Maybe @fredg02 can answer that.
Let's do it at once in the next dev cycle. |
It's a group repository and it combines the releases and the snapshots repositories. You can also see all of the group repos here: |
Acknowledge.
Thank you for the confirmation. Good to know. |
From the three declared Eclipse CBI plugin repositories only the maven-plugins with groupId 'org.eclipse.cbi.maven.plugins' are obtained. And at least with respect to these mavne-plugins, the repository at
seems to be the combination of the co-located repositories:
Therefore it seems unnecessary to declare all three repositories.
@akurtakov can you tell if my analysis and this change is correct or if not, can you tell who can tell?