[GTK][HiDpi] Code cleanup for removal of non-cairo scale path

[deepika-u]

Fixes #1300

[github-actions]

Test Results

  281 files   -   204    281 suites   - 204   5m 19s ⏱️ - 3m 32s
4 139 tests  -    19  4 123 ✅  -    26   7 💤  -  1  3 ❌ +2  6 🔥 +6 
8 209 runs   - 8 177  8 144 ✅  - 8 149  56 💤  - 36  3 ❌ +2  6 🔥 +6 

For more details on these failures and errors, see this check.

Results for commit ff050b1. ± Comparison against base commit 02e20d6.

This pull request removes 19 tests.

org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_emptyString
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letterA
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16LE_null
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_letter
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

[deepika-u]

@SyntevoAlex @akurtakov @merks @sravanlakkimsetti
Can you review this please.

[SyntevoAlex]

Sorry, I don't think I can find time to review.

[deepika-u]

@akurtakov @iloveeclipse
These are the changes done as per @sravanlakkimsetti's suggestions, so can one of you review the changes please.

[deepika-u]

@akurtakov @iloveeclipse : Can you review this pr please?

[akurtakov]

@deepika-u It's not even compiling as can be seen in the logs:

17:31:20  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.swt.gtk.linux.x86_64: Compilation failure: Compilation failure: 

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[673] 

17:31:20  [ERROR] 	height += getSpacingInPixels();

17:31:20  [ERROR] 	          ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[704] 

17:31:20  [ERROR] 	int yExtent = extent ? getSpacingInPixels() : 0;

17:31:20  [ERROR] 	                       ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] 4 problems (2 errors, 2 warnings)

[deepika-u]

@deepika-u It's not even compiling as can be seen in the logs:

17:31:20  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.swt.gtk.linux.x86_64: Compilation failure: Compilation failure: 

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[673] 

17:31:20  [ERROR] 	height += getSpacingInPixels();

17:31:20  [ERROR] 	          ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[704] 

17:31:20  [ERROR] 	int yExtent = extent ? getSpacingInPixels() : 0;

17:31:20  [ERROR] 	                       ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] 4 problems (2 errors, 2 warnings)

Thanks alot for reviewing this pr. I did the needed changes to TextLayout.java and those 2 errors are gone. Sorry it was a miss from my side.

But now seeing error "The method org.eclipse.swt.graphics.Image.getBoundsInPixels() has been removed". For this if i change the version from 3.128.0.qualifier to 4.0.0, this error is gone. Should i be doing this change also? Do you also see this error with respect to Image.java and MANIFEST.MF files?

[akurtakov]

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

[deepika-u]

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

@akurtakov: Reverted the changes of Image.java, now when pr is applied i am not finding any errors. Can you please review now? Thanks alot in advance.

[akurtakov]

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

@akurtakov: Reverted the changes of Image.java, now when pr is applied i am not finding any errors. Can you please review now? Thanks alot in advance.

Before asking me for review again please look at the build output . Automated build and tests are there so contributors see when things don't compile (previous case) or when tests fail(https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1304/18/) like now. Please make sure that you have checked all fails and have a clean build before asking explicitly.

[deepika-u]

Please make sure that you have checked all fails and have a clean build before asking explicitly.

Thanks for letting me know on another check(which i didnt knew), i shall check on them.