Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK4] Migrate deprecated FontChooser to FontDialog #1583

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[GTK4] Migrate deprecated FontChooser to FontDialog #1583

wants to merge 2 commits into from

Commits on Nov 9, 2024

  1. [GTK4] Cleanup execution of non-blocking dialog calls 

    This adds a new AsyncReadyCallback class which is used to handle the
asynchronous execution of dialogs. The goal is provide a cleaner and
more readable interface than what is currently available by
SyncDialogUtil.

Note that this class currently simply wraps the call to SyncDialogUtil.
But once all of the remaining dialogs (Color/Font/MessageDialog) have
been migrated, it might make sense to remove this class entirely to
avoid this additional indirection.

Follow-up to 2e61b4b
    @ptziegler
    ptziegler committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    4bc5322 View commit details
    Browse the repository at this point in the history

  2. [GTK4] Migrate deprecated FontChooser to FontDialog 

    This moves all native FontChooser bindings from the shared GTK to the
GTK3 component and also defines new GTK4 bindings for the FontDialog
API.

Note: The FontDialog doesn't seem to remember the initial font that is
passed as an argument. This looks like a bug within GTK, given that the
same behavior also happens for the FontDialogButton[1].

[1] - https://gitlab.gnome.org/GNOME/gtk/-/issues/6892
    @ptziegler
    ptziegler committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    7c29698 View commit details
    Browse the repository at this point in the history