Skip to content

Replace File Extension based on user selection #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace File Extension based on user selection #2620

wants to merge 1 commit into from

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Oct 13, 2025 •
edited
Loading

Refs: #2566

Fix file extension in macOS

Previously, the FileDialog would only append the selected file extension if there is no extension attached to the filename. However, if the filename already had an extension, it has to removed to accommodate the user input extension.
This PR updates the implementation to replace the existing extension with the user input file extension.

@elsazac elsazac changed the title Replace File Extension Based on Filter Selection Replace File Extension based on user selection Oct 13, 2025
@elsazac
Copy link
Member Author

elsazac commented Oct 13, 2025

@vogella Could you check this?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025 •
edited
Loading

Test Results

104 files   -    11  104 suites   - 11   6s ⏱️ - 13m 0s
 80 tests  - 4 474   80 ✅  - 4 458  0 💤  - 16  0 ❌ ±0 
255 runs   -    56  255 ✅  -    53  0 💤  -  3  0 ❌ ±0 

Results for commit 7f931cb. ± Comparison against base commit ac18a18.

This pull request removes 4474 tests. 
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Oct 13, 2025

LGTM from looking at the code

@vogella
Copy link
Contributor

vogella commented Oct 15, 2025

@orionll please confirm that this patch solves your problem

@orionll
Copy link

orionll commented Oct 16, 2025

@vogella, with this change the dialog returns a correct extension.

@vogella
Copy link
Contributor

vogella commented Oct 16, 2025

@elsazac thanks for the fix and thanks @orionll for testing.

Please merge

@elsazac
Fix the fileExtension issue in macOS.
7f931cb 
Currently if there is no file extension for the file, then only the new
extension is getting appended; but there is no implementation if there
is an extension already present for the file and the user wants to
overwrite it;

The PR is raised to include that condition too.
@MohananRahul MohananRahul mentioned this pull request Oct 17, 2025
Closed
@MohananRahul
Copy link
Contributor

Build failing due to eclipse-tycho/tycho#5473

@laeubi
Copy link
Contributor

laeubi commented Oct 17, 2025

Build failing due to eclipse-tycho/tycho#5473

Nope... see comment. Either Infrastructure is unstable or some changes in PDE/ApiTools related in Platform... One might want to run a local maven build and attach a debugger to see what actually is missing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vogella vogella vogella approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elsazac @vogella @orionll @MohananRahul @laeubi