[Win32] Only scale menu item images on monitor-specific scaling #2537 #2648
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-platform#2537 The current mechanism to adapt the size of menu item images based on Windows system metrics, primary monitor zoom at startup and the current monitor zoom ensures that menu item images always fit to the required size for that menu. Since menus and their sizes are managed by the OS, adapting the image size as currently implemented leads to the best fitting image sizes. However, this behavior is incompatible with the assumptions one could previously make on the sizes of those images. In particular, depending on the used auto-scale mode different kinds of scaling for those images were in place. To achieve the best solution for all cases, this change results in the following: - When monitor-specific scaling is enabled, menu item images are properly scaled as required for the menu. This is independent of whether any other additional legacy settings regarding auto-scaling is made, which will be overwritten by this. - When monitor-specific scaling is disabled, the previous behavior is restored such that images are just scaled depending on the auto-scale mode but do not take into account which size is actually needed for that menu. Fixes eclipse-platform#2537
|
@tmssngr this is hopefully the best tradeoff for all current use cases. It should use the new, proper menu scaling when monitor-specific scaling is enabled (without any additional auto-scaling settings), and it should use the unmodified preexisting scaling behavior when monitor-specific scaling is disabled (to allow backwards compatibilities). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mechanism to adapt the size of menu item images based on Windows system metrics, primary monitor zoom at startup and the current monitor zoom ensures that menu item images always fit to the required size for that menu. Since menus and their sizes are managed by the OS, adapting the image size as currently implemented leads to the best fitting image sizes.
However, this behavior is incompatible with the assumptions one could previously make on the sizes of those images. In particular, depending on the used auto-scale mode different kinds of scaling for those images were in place.
To achieve the best solution for all cases, this change results in the following:
Fixes #2537
How to test
The issue can be reproduced and the fix tested with the snippet given in the original issue:
It also allows to test different combinations of auto-scale properties together with menus.