Warnings and webserver for test and other cleanups#2838
Closed
jonahgraham wants to merge 10 commits intoeclipse-platform:masterfrom
Closed
Warnings and webserver for test and other cleanups#2838jonahgraham wants to merge 10 commits intoeclipse-platform:masterfrom
jonahgraham wants to merge 10 commits intoeclipse-platform:masterfrom
Conversation
Contributor
jonahgraham
force-pushed
the
warnings-and-webserver-for-test-and-other-cleanups
branch
from
0862f36 to
3b2f8a7
Compare
Contributor
Author
|
There are a couple of warnings left - I am spinning up an mac + windows machine to build and test the changes to the code. |
jonahgraham
force-pushed
the
warnings-and-webserver-for-test-and-other-cleanups
branch
from
3b2f8a7 to
cc28520
Compare
For a while we have suffered with patchy tests due to limited connectivity to external websites when running Browser tests. This commit brings in a new Http Server based on the now available Java 21 simple web server available in the JDK. This is sufficient to test the various paths currently used in the browser tests, and make them reliable (or at least more resilient against external sites going dark) Fixes eclipse-platform#2804 Fixes eclipse-platform#2561
The NPE was output to System.err because nothing catches it, but its running on a thread. The code worked, but System.err would have ``` Exception in thread "Thread-2" java.lang.NullPointerException: Cannot invoke "String.indexOf(int)" because "content_type" is null at org.eclipse.swt.browser.WebKit.lambda$14(WebKit.java:2186) at java.base/java.lang.Thread.run(Thread.java:1583) ``` or similar.
Finalization is deprecated for removal in Java, as of now there is no actual removal date planned so simply suppressing the warning seems most suitable.
Includes adding a handful of new tests for the code that this modifies to cover all the special cases. The new tests are Linux only, but they could be adapted to test these error conditions on other platforms.
These calls are covered by existing Browser test cases.
There were lots of links to the old style URLs of webkitgtk that are updated with this commit. Most of the udpates are fairly self-evidently correct as the URLs are very similar. For `Webkit2 Signal Documentation` the link was to the `title` *property*, so the new links are to the signals section For javadoc on `webkit_web_view_ready` the documentation was to `unstable` for a signal called `ready` - the correct signal is `ready_to_show` (the code used `ready_to_show`, only the link was wrong)
`Widget.removeListener(int, SWTEventListener)` is deprecated for removal, but it references `SWTEventListener` so there was a deprecation warning. `TypedListener(SWTEventListener)` is deprecated for removal, but it references `SWTEventListener` so there was a deprecation warning.
jonahgraham
force-pushed
the
warnings-and-webserver-for-test-and-other-cleanups
branch
from
2c80235 to
316f134
Compare
Contributor
Author
|
This PR is not for submitting - its too big and being split up as we speak. |
This was referenced Dec 2, 2025
jonahgraham
deleted the
warnings-and-webserver-for-test-and-other-cleanups
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up for #2824 as one big PR with bug fixes, warning removals, and other cleanups all mixed together.
I will split this PR into bite-size pieces later, but I want to make sure that this PR does indeed remove the extra warnings and issues that #2824 has introduced.
This isn't marked as a draft so it runs on Jenkins too - its not really ready for review.