Proposal: Opening/Closing Mechanism for Zip Files #1413
Commits on Sep 25, 2024
-
Proposal: Opening/Closing Mechanism for Zip Files
The Eclipse IDE has no built in functionality to open Zip Files and read or manipulate their content. Because of this, other operations like searching inside of Zip Files or comparing two Zip Files were also not possible. This pull request introduces a mechanism for handling Zip Files within the Eclipse workspace, enhancing the functionality to read and write Zip files. The primary goal is to provide a seamless experience for developers working with zip archives directly within Eclipse. Zip files must be opened manually within the workspace by using the new command "Open Zip File" in the menu when right clicking the zip file. It is also possible to open nested zip files. Zip Files are opened by replacing the file in the workspace with a linked folder that reads and writes the Zip File in the file system. By closing the Zip FIle, the linked folder will be deleted and the file can be seen in the workspace again. Please note that only ZIP Archives are supported in this current implementation. Other archive types can be added in future improvements. Also linked Zip Files can not be opened with this implementation because the Zip File must be local. An additional PR for the repository **eclipse.platform.ui** that grants access to the open/close mechanism for zip files over UI can be found in the following: eclipse-platform/eclipse.platform.ui#1947 Co-Authored-By: David Erdös <[email protected]> fix rebase
-
remove progressMonitor and ProgressDialog
The progress monitor used in ZipFileTransformer#openZipFile was necessary in previous versions because performance issues were present. now it is useless and is thus be removed.
-
remove parametrization for tests
parametrization for tests is removed because it makes trouble building a good test name within build jobs
-
-
-
-
change checkFileForZipHeader with header check to canZipFileBeOpened …
…with nio open check
-
-
-
temporary workaround for gender issues
temporary workaround for CloseTest#testCloseZipFileWithZipFileUnderneath
-
-
-
Introduce Lock mechanism to ZipFileStore
This change fixes various problems regarding ClosedZipFileSystemException, NoZipFileSystemFoundException and ZipFileSystemAlreadyExistsException
-
-
-
The default value of create is false
-
-
All ZIP-based zip files like zip, jar and war can be put on the classpath of the project. To avoid UI bugs, only zip files can be opened that are not added to the project's classpath. This commit introduces a check for the classpath.
-
-
-
-
Revert "new test concurrencyTest"
This reverts commit cc797ed.
-
-
-
-
Revert "Allow WAR and JAR files"
This reverts commit 9e3d212.
-
to make sure that clients like JDT do not have a behaviour change or even errors the code for opening zip files is encapsulated in a IWorkspaceRunnable. This allows opening zip files on the class path.
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.