-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show diff in "replace with local history" dialog on selection change #1625
base: master
Are you sure you want to change the base?
show diff in "replace with local history" dialog on selection change #1625
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
} | ||
private Tree getTree(IPage page) { | ||
Control control = page.getControl(); | ||
if (control instanceof Composite c) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here a lot of nesting is happening.
Can we decrease that by returning null early?
da92e2a
to
874a1d2
Compare
Issue was detected in an internal UX review. UX experts were asking us why the UI is not updated when an entry in the history list is selected. Question is absolutely valid from my point of view. |
The "Replace With" -> "Local History ..." option in the source editor context menu launches a dialog that allows users to revert to a previous version. Initially, this dialog displays a list of all available revisions:
Previously, selecting an entry from the revision list did not trigger any action. Users had to double-click to view the differences.
This pull request enhances the behavior by displaying the differences upon a single click/selection.