Skip to content

Conversation

SougandhS
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 35m 51s ⏱️ - 3m 22s
 4 720 tests ±0   4 696 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 160 runs  ±0  13 993 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 7031488. ± Comparison against base commit 316cc9c.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Contributor

laeubi commented Aug 6, 2025

As it might be that the wrong attribute name is used in existing data, should at least reading the wrong name be used to recover such values?

@merks
Copy link
Contributor

merks commented Aug 6, 2025

Yes, of course this is used in a memento to serialize the value so all existing serializations will lose that value and that can't be a good thing.

@SougandhS
Copy link
Contributor Author

I can keep attribute value as misspelled and refactor variables name only

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 8fac40894e0bcb820e826df61b93a2bff78fba48 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 4 Sep 2025 07:09:34 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 81279072c8..860867d420 100644
--- a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.19.0.qualifier
+Bundle-Version: 3.19.100.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants