Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editing features to Langium-based example #106

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

spoenemann
Copy link
Contributor

These operations are now possible with a side-by-side view of the Langium-based States editor and a Sprotty view.

  • Select a state or transition and press delete 👉 the respective text range is deleted
  • Double-click a state name 👉 a dialog appears where you can enter a new name
  • Double-click a transition event 👉 a dialog appears where you can choose another event
  • Hover on the diagram background 👉 a pop-up appears with buttons to create a new state or event

Does not work, to be fixed later:

  • Drag the little triangle on the right side of a node to create a new transition
  • Select a transition, then drag the source or target handle to change the source or target state

Copy link
Contributor

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really good!
Small things I noticed:

  • In the Xtext example the hover menu is not rendered properly (is empty)
  • Also in the Xtext example LS throws java.lang.IllegalArgumentException: Unknown action kind: languageLabelEdit. Editing works as expected.
  • If possible do not render hover menu in the View example as it doesn't work

@spoenemann
Copy link
Contributor Author

I'd remove the Xtext example as we can't maintain it anymore.

@spoenemann spoenemann merged commit 85e9c1c into master Jun 17, 2024
2 checks passed
@spoenemann spoenemann deleted the edit-states-langium branch June 17, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants