-
Notifications
You must be signed in to change notification settings - Fork 208
feat(KeyCloak) : Migrate KeyCloak-SW360 Database Communication #3406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(KeyCloak) : Migrate KeyCloak-SW360 Database Communication #3406
Conversation
…ect CouchDB Access
…ect CouchDB Access
6bccbad to
0f99f31
Compare
GMishx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few optimization suggestions.
...teners/src/main/java/org/eclipse/sw360/keycloak/event/listener/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...teners/src/main/java/org/eclipse/sw360/keycloak/event/listener/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...teners/src/main/java/org/eclipse/sw360/keycloak/event/listener/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...teners/src/main/java/org/eclipse/sw360/keycloak/event/listener/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...-storage-provider/src/main/java/org/eclipse/sw360/keycloak/spi/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...-storage-provider/src/main/java/org/eclipse/sw360/keycloak/spi/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...-storage-provider/src/main/java/org/eclipse/sw360/keycloak/spi/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
...-storage-provider/src/main/java/org/eclipse/sw360/keycloak/spi/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
…ect CouchDB Access
…cation_to_Direct_CouchDB_Access Signed-off-by: bibhuti230185 <[email protected]>
GMishx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more things left out.
...-storage-provider/src/main/java/org/eclipse/sw360/keycloak/spi/service/Sw360UserService.java
Outdated
Show resolved
Hide resolved
…ect CouchDB Access
dbc23fd to
67f4a8d
Compare
GMishx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
|
@bibhuti230185 , please rebase the branch to resolve the conflicts |
…cation_to_Direct_CouchDB_Access Signed-off-by: bibhuti230185 <[email protected]>
|
I just tested the branch. Have some findings to be looked into @bibhuti230185 :
|
|
@GMishx , Thanks for the review. |
|
|
Please add the following SPI configuration and restart the keycloak server SW360 SPI ConfigurationEvent listener SPI for adding users to CouchDBspi-events-listener-sw360-add-user-to-couchdb-couchdb-url= User storage SPI for reading users from SW360 databasespi-storage-sw360-user-storage-jpa-couchdb-url= |
|
@bibhuti230185 , I just tested using the SPI variables in my config and the update of user still failed with following error: And syncing all users still fails with message 'Synchronization ignored as it's already in progress.' and nothing else happens. |
…ect CouchDB Access
Migrate KeyCloak-SW360 Database Communication to Direct CouchDB Access
Overview
This PR migrates KeyCloak’s database communication from Thrift via the SW360 application to a direct CouchDB connection using library functions. This decouples KeyCloak from the SW360 application, allowing both to run independently and improving performance.
Changes
Test Cases (all completed)
Impact
Closes #3405
Suggest Reviewer
@GMishx