Skip to content

feat(REST): Add includeSubproject parameter to licenseInfo #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(REST): Add includeSubproject parameter to licenseInfo #3478

wants to merge 1 commit into from

Conversation

@afsahsyeda
Copy link
Contributor

@afsahsyeda afsahsyeda commented Nov 4, 2025

Description

  • Configure the inclusion of subprojects while generating license info for a project.
  • Set to true by default to preserve existing behavior.

@afsahsyeda afsahsyeda added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Nov 4, 2025
@akshitjoshii
Copy link
Contributor

akshitjoshii commented Nov 4, 2025

Test successful.

@akshitjoshii akshitjoshii removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Nov 4, 2025
akshitjoshii
akshitjoshii previously approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@akshitjoshii akshitjoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshitjoshii akshitjoshii added ready ready to merge and removed needs code review labels Nov 4, 2025
@GMishx
Copy link
Member

GMishx commented Nov 5, 2025

@afsahsyeda
Just checking the code logic, if includeSubprojects is set as false, the sw360Project remains unused.

And the mappedProjectLinks.forEach on line 1599 would never execute. Logically, it means no attached releases will be processed, meaning no information in the LicenseInfo report generated.

Did I assume it correctly or did I miss something?

@GMishx GMishx added needs code review and removed ready ready to merge labels Nov 5, 2025
@afsahsyeda afsahsyeda force-pushed the feat/REST/licenseINfo/addSubprojectsParameter branch from 8b62349 to 6f47d70 Compare November 6, 2025 10:31
@afsahsyeda
Copy link
Contributor Author

afsahsyeda commented Nov 6, 2025

@afsahsyeda Just checking the code logic, if includeSubprojects is set as false, the sw360Project remains unused.

And the mappedProjectLinks.forEach on line 1599 would never execute. Logically, it means no attached releases will be processed, meaning no information in the LicenseInfo report generated.

Did I assume it correctly or did I miss something?

@GMishx You were right. I have added the missing logic. Please have a look.

@afsahsyeda afsahsyeda force-pushed the feat/REST/licenseINfo/addSubprojectsParameter branch from 6f47d70 to beef8b6 Compare November 6, 2025 10:33
GMishx
GMishx approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@akshitjoshii can you please help retest the changes (with and without the sub-projects)?

@GMishx GMishx added needs general test This is general testing, meaning that there is no org specific issue to check for and removed needs code review labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GMishx GMishx GMishx approved these changes

@akshitjoshii akshitjoshii akshitjoshii left review comments

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees

@akshitjoshii akshitjoshii

Labels

needs general test This is general testing, meaning that there is no org specific issue to check for

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afsahsyeda @akshitjoshii @GMishx