Skip to content

Conversation

@fdesbiens
Copy link
Contributor

No description provided.

mdkf and others added 30 commits April 2, 2025 14:32
…potential buffer overflow due to incorrect pointer being passed to HMAC cleanup if NetX is build with NX_SECURE_KEY_CLEAR defined.
It was causing some tests to hang forever because they were expecting
different errors to be returned. We do want to keep the check for
empty packets as the netx_web_invalid_release_test expects that
sending an empty packet fails. Note that the test also tests HTTPS,
which will technically send a non-empty packet because the empty
packet will be modified to include the TLS data. However, the
empty packet check in nx_secure_tls_session_send will fulfill the
same role as the check in nx_tcp_socket_send.c, checking for
an empty packet prior to the modification of the packet to include
TLS data.

This gets the tests passing again.
The check is in the function
_nx_secure_tls_process_clienthello_psk_extension and was reported
as a vulnerability.
It was causing some tests to hang forever because they were expecting
different errors to be returned. We do want to keep the check for
empty packets as the netx_web_invalid_release_test expects that
sending an empty packet fails. Note that the test also tests HTTPS,
which will technically send a non-empty packet because the empty
packet will be modified to include the TLS data. However, the
empty packet check in nx_secure_tls_session_send will fulfill the
same role as the check in nx_tcp_socket_send.c, checking for
an empty packet prior to the modification of the packet to include
TLS data.

This gets the tests passing again.
edited by inspection not compiled or run-time tested
edited by inspection not compiled or run-time tested
edited by inspection not compiled or run-time tested
The header Sec-WebSocket-Protocol is optional in both the
request and the response from the server.

Signed-off-by: Joel Guittet <[email protected]>
The Authorization: Bearer header allow to perform authentication
providing a token. It is optional.

Signed-off-by: Joel Guittet <[email protected]>
Implementation of ECDHE_PSK cipher suites
Fixes an issue in nx_secure_tls_psk_identity_find()
Fix multiple NextX Duo vulnerabilities.
Fix PSK extension length checking, add tests for such
Fix length checking in supported version extension, add test
Fixed issue in _nx_secure_tls_process_clienthello()
Insert a remaining buffer length check before dereferencing the pointer
Added buffer length check
Insert a index position check before getting bytes
Insert a buffer_ptr position check before getting bytes
Fix HKDF implementation to prevent buffer overrun when compiled with NX_SECURE_KEY_CLEAR
* Restored ECC_CIPHERSUITE ifdef code.
* Added ifdefs to exclude PSK code when build options require it.
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results MQTT_Interoperability

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results NetXDuo

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results PTP

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results Crypto

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results Secure

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results Secure_Interoperability

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results NetXDuo64

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results MQTT

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results Azure_IoT

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results NetXDuo_Fast

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results Web

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 582a360. ± Comparison against base commit 5af33d7.

@fdesbiens fdesbiens merged commit 8d84ebe into master Oct 2, 2025
23 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants